From: cyrille.pitchen@atmel•com (Cyrille Pitchen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller
Date: Tue, 25 Aug 2015 13:24:20 +0200 [thread overview]
Message-ID: <55DC5064.6050500@atmel.com> (raw)
In-Reply-To: <A765B125120D1346A63912DDE6D8B6310BF47A26@NTXXIAMBX02.xacn.micron.com>
Hi!
Le 25/08/2015 03:44, Bean Huo ??? (beanhuo) a ?crit :
>
>> + nor->read_reg = atmel_qspi_read_reg;
>> + nor->write_reg = atmel_qspi_write_reg;
>> + nor->read = atmel_qspi_read;
>> + nor->write = atmel_qspi_write;
>> + nor->erase = atmel_qspi_erase;
>> + nor->set_protocol = atmel_qspi_set_protocol;
>
> This is very good, the structure of spi_nor should add a hook function to notify spi controller
> That spi nor transfer protocol already changed.
>
>> +
>> + if (of_modalias_node(child, modalias, sizeof(modalias)) < 0) {
>> + err = -ENODEV;
>> + goto release_channel;
>> + }
>> +
>> + err = of_property_read_u32(child, "spi-max-frequency", &aq->clk_rate);
>> + if (err < 0)
>> + goto release_channel;
>> +
>> + err = atmel_qspi_init(aq);
>> + if (err)
>> + goto release_channel;
>> +
>> + nor->dev->of_node = child;
>> + err = spi_nor_scan(nor, modalias, SPI_NOR_QUAD);
>> goto release_channel;
>> +
>
>
> .......
>
>> static inline struct spi_nor *mtd_to_spi_nor(struct mtd_info *mtd) {
> return mtd->priv;
>> @@ -944,6 +960,11 @@ static int micron_quad_enable(struct spi_nor *nor)
>> return ret;
>> }
>>
>> + /* switch protocol to Quad CMD 4-4-4 */
>> + ret = spi_nor_set_protocol(nor, SPI_PROTO_4_4_4);
>> + if (ret)
>> + return ret;
>> +
>
> This make sense,from spi nor side,once its protocol being changed,
> Mtd layer must notify this status to spi nor controller immediately,
> And spi nor controller also should re-adjust its protocol.
> Otherwise, following reading SR operation will fail.
>
>>
>> ret = spi_nor_wait_till_ready(nor);
>> if (ret)
>> return ret;
>
> If my ack has any value in here, feel free to add it.
>
> Acked-by: Bean Huo <beanhuo@micron•com>
>
Since your comments deal with the protocol change, I'll add your ack to the
first patch of the series:
"mtd: spi-nor: notify (Q)SPI controller about protocol change"
Thanks for your review!
Best regards,
Cyrille
prev parent reply other threads:[~2015-08-25 11:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 10:13 [PATCH linux-next v4 0/5] add driver for Atmel QSPI controller Cyrille Pitchen
2015-08-24 10:13 ` [PATCH linux-next v4 1/5] mtd: spi-nor: notify (Q)SPI controller about protocol change Cyrille Pitchen
2015-08-24 10:16 ` Marek Vasut
2015-08-24 10:13 ` [PATCH linux-next v4 2/5] Documentation: mtd: add a DT property to set the number of dummy cycles Cyrille Pitchen
2015-08-24 10:13 ` [PATCH linux-next v4 3/5] mtd: spi-nor: allow to tune " Cyrille Pitchen
2015-08-24 10:48 ` Marek Vasut
2015-08-24 16:42 ` Cyrille Pitchen
2015-08-24 16:48 ` Marek Vasut
2015-08-24 10:13 ` [PATCH linux-next v4 4/5] Documentation: atmel-quadspi: add binding file for Atmel QSPI driver Cyrille Pitchen
2015-08-24 10:22 ` Marek Vasut
2015-08-24 10:14 ` [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller Cyrille Pitchen
2015-08-24 11:03 ` Marek Vasut
2015-08-24 12:49 ` Russell King - ARM Linux
2015-08-24 13:15 ` Marek Vasut
2015-08-24 17:04 ` Cyrille Pitchen
2015-08-24 17:45 ` Marek Vasut
2015-08-25 9:46 ` Jonas Gorski
2015-08-25 10:21 ` Cyrille Pitchen
2015-08-25 10:17 ` Cyrille Pitchen
2015-08-25 10:22 ` Marek Vasut
2015-08-25 15:57 ` Brian Norris
2015-08-25 1:44 ` Bean Huo 霍斌斌 (beanhuo)
2015-08-25 11:24 ` Cyrille Pitchen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC5064.6050500@atmel.com \
--to=cyrille.pitchen@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox