From: javier@osg•samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
Date: Thu, 27 Aug 2015 14:23:15 +0200 [thread overview]
Message-ID: <55DF0133.2070009@osg.samsung.com> (raw)
In-Reply-To: <CAPAsAGyrEm--=WfGB4wSFSXE8HZpp+HDuV=p4JmFbV-X2keQCg@mail.gmail.com>
Hello Andrey,
On 08/27/2015 02:20 PM, Andrey Ryabinin wrote:
> 2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <javier@osg•samsung.com>:
>> These platform drivers have a platform device ID table but the module
>> alias information is not created so module autoloading will not work.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg•samsung.com>
>>
>> ---
>>
>> drivers/rtc/rtc-ab8500.c | 1 +
>> drivers/rtc/rtc-max8997.c | 1 +
>> drivers/rtc/rtc-s5m.c | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
>> index 133d2e2e1a25..8537d1e3a995 100644
>> --- a/drivers/rtc/rtc-ab8500.c
>> +++ b/drivers/rtc/rtc-ab8500.c
>> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
>> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
>> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
>
> Completely irrelevant, but this array should have an empty terminating element.
>
You are right, it's missing a sentinel indeed. But
that change should be done in a separate patch.
>> };
>> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
>>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-08-27 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 10:34 [PATCH] rtc: Fix module autoload for rtc-{ab8500, max8997, s5m} drivers Javier Martinez Canillas
2015-08-27 12:20 ` Andrey Ryabinin
2015-08-27 12:23 ` Javier Martinez Canillas [this message]
2015-08-28 0:27 ` [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers Krzysztof Kozlowski
2015-08-31 20:09 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DF0133.2070009@osg.samsung.com \
--to=javier@osg$(echo .)samsung.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox