From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module
Date: Thu, 03 Sep 2015 14:02:48 +0900 [thread overview]
Message-ID: <55E7D478.2020200@samsung.com> (raw)
In-Reply-To: <1441253429-3264-1-git-send-email-linux.amoon@gmail.com>
On 03.09.2015 13:10, Anand Moon wrote:
> S3C2410_WATCHDOG watchdog drivers should not be loaded automatically,
> but only if a watchdog daemon is installed.
First of all: why?
Secondly: even as a module driver could be loaded automatically to match
enabled device (it has MODULE_DEVICE_TABLE). In the same time loading it
does not hurt - watchdog should be inactive:
s3c2410-wdt 10060000.watchdog: watchdog inactive, reset disabled, irq
disabled
Best regards,
Krzysztof
>
> Signed-off-by: Anand Moon <linux.amoon@gmail•com>
> ---
> arch/arm/configs/exynos_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index aaf7aa4..b5d382e 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -101,7 +101,7 @@ CONFIG_CPU_THERMAL=y
> CONFIG_THERMAL_EMULATION=y
> CONFIG_EXYNOS_THERMAL=y
> CONFIG_WATCHDOG=y
> -CONFIG_S3C2410_WATCHDOG=y
> +CONFIG_S3C2410_WATCHDOG=m
> CONFIG_MFD_CROS_EC=y
> CONFIG_MFD_CROS_EC_I2C=y
> CONFIG_MFD_CROS_EC_SPI=y
>
next prev parent reply other threads:[~2015-09-03 5:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 4:10 [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module Anand Moon
2015-09-03 5:02 ` Krzysztof Kozlowski [this message]
2015-09-03 5:20 ` Anand Moon
2015-09-04 6:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E7D478.2020200@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox