From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv4 2/5] net: phy: extend fixed driver with fixed_phy_register()
Date: Thu, 3 Sep 2015 22:55:25 +0300 [thread overview]
Message-ID: <55E8A5AD.4050908@cogentembedded.com> (raw)
In-Reply-To: <55E8A1AB.305@openwrt.org>
On 09/03/2015 10:38 PM, Florian Fainelli wrote:
>>>> The existing fixed_phy_add() function has several drawbacks that
>>>> prevents it from being used as is for OF-based declaration of fixed
>>>> PHYs:
>>>>
>>>> * The address of the PHY on the fake bus needs to be passed, while a
>>>> dynamic allocation is desired.
>>>>
>>>> * Since the phy_device instantiation is post-poned until the next
>>>> mdiobus scan, there is no way to associate the fixed PHY with its
>>>> OF node, which later prevents of_phy_connect() from finding this
>>>> fixed PHY from a given OF node.
>>>>
>>>> To solve this, this commit introduces fixed_phy_register(), which will
>>>> allocate an available PHY address, add the PHY using fixed_phy_add()
>>>> and instantiate the phy_device structure associated with the provided
>>>> OF node.
>>>>
>>>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
>>>> Acked-by: Florian Fainelli <f.fainelli@gmail•com>
>>>> Acked-by: Grant Likely <grant.likely@linaro•org>
>>>> ---
>>>> drivers/net/phy/fixed.c | 61
>>>> +++++++++++++++++++++++++++++++++++++++++++++++
>>>> include/linux/phy_fixed.h | 11 +++++++++
>>>> 2 files changed, 72 insertions(+)
>>>>
>>>> diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
>>>> index e41546d..d60d875 100644
>>>> --- a/drivers/net/phy/fixed.c
>>>> +++ b/drivers/net/phy/fixed.c
>>> [...]
>>>> @@ -203,6 +204,66 @@ err_regs:
>>> [...]
>>>> +int fixed_phy_register(unsigned int irq,
>>>> + struct fixed_phy_status *status,
>>>> + struct device_node *np)
>>>> +{
>>>> + struct fixed_mdio_bus *fmb = &platform_fmb;
>>>> + struct phy_device *phy;
>>>> + int phy_addr;
>>>> + int ret;
>>>> +
>>>> + /* Get the next available PHY address, up to PHY_MAX_ADDR */
>>>> + spin_lock(&phy_fixed_addr_lock);
>>>> + if (phy_fixed_addr == PHY_MAX_ADDR) {
>>>> + spin_unlock(&phy_fixed_addr_lock);
>>>> + return -ENOSPC;
>>>> + }
>>>> + phy_addr = phy_fixed_addr++;
>>>> + spin_unlock(&phy_fixed_addr_lock);
>>>> +
>>>> + ret = fixed_phy_add(PHY_POLL, phy_addr, status);
>>>
>>> Was rummaging in the fixed_phy driver and a bug sprang right at
>>> me: 'phy'
>>
>> Sorry, s/phy/irq/ of course. Just noticed. :-/
I've reported the bug on #miplsinux, there I used the correct word. :-)
> Ok, that makes sense then, and yes, this "irq" argument should have been
> passed down to fixed_phy_add(). Might be worth adding a WARN_ON(irq !=
> PHY_POLL) just to catch callers that expect something else.
In-tree callers all seem to pass PHY_POLL to fixed_phy_register(). Do we
care about out of tree stuff?
> Thanks!
> --
> Florian
MBR, Sergei
next prev parent reply other threads:[~2015-09-03 19:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 14:14 [PATCHv4 0/5] Add DT support for fixed PHYs Thomas Petazzoni
2014-05-16 14:14 ` [PATCHv4 1/5] net: phy: decouple PHY id and PHY address in fixed PHY driver Thomas Petazzoni
2014-05-16 18:30 ` Florian Fainelli
2014-05-16 14:14 ` [PATCHv4 2/5] net: phy: extend fixed driver with fixed_phy_register() Thomas Petazzoni
2014-05-16 18:28 ` Florian Fainelli
2015-09-03 19:20 ` Sergei Shtylyov
2015-09-03 19:23 ` Florian Fainelli
2015-09-03 19:35 ` Sergei Shtylyov
2015-09-03 19:37 ` Sergei Shtylyov
2015-09-03 19:38 ` Florian Fainelli
2015-09-03 19:55 ` Sergei Shtylyov [this message]
2014-05-16 14:14 ` [PATCHv4 3/5] of: provide a binding for fixed link PHYs Thomas Petazzoni
2014-05-16 18:29 ` Florian Fainelli
2014-05-16 14:14 ` [PATCHv4 4/5] net: mvneta: add support for fixed links Thomas Petazzoni
2014-05-16 14:14 ` [PATCHv4 5/5] ARM: mvebu: use the fixed-link PHY DT binding for the Armada XP Matrix board Thomas Petazzoni
2014-05-16 18:27 ` [PATCHv4 0/5] Add DT support for fixed PHYs Florian Fainelli
2014-05-16 20:46 ` Thomas Petazzoni
2014-05-16 21:20 ` David Miller
2014-05-18 10:18 ` Thomas Petazzoni
2014-05-18 17:21 ` Florian Fainelli
2014-05-18 17:46 ` Thomas Petazzoni
2014-05-18 23:07 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E8A5AD.4050908@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox