From: shawn.lin@rock-chips•com (Shawn Lin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1
Date: Fri, 4 Sep 2015 08:03:26 +0800 [thread overview]
Message-ID: <55E8DFCE.5040504@rock-chips.com> (raw)
In-Reply-To: <20150903174502.GI5313@sirena.org.uk>
On 2015/9/4 1:45, Mark Brown wrote:
> On Thu, Sep 03, 2015 at 09:41:43PM +0800, Shawn Lin wrote:
>> On 2015/9/3 20:54, Mark Brown wrote:
>
>>> If this is a quirk of the DMA controller why is it being fixed with a
>>> property specific to the SPI controller? Can't the DMA controller just
>>> override the burst size?
>
>> Cool...that's a good question. Actually DMA controller can't do that since
>> block peripheral controller(e.g sd/emmc, they always access data by
>> block-512Bytes.) can't meet the case. So It's hard for dma controller know
>> who is the caller, and what should be done.
>
> You could take a guess based on request size, but that's going to be a
> bit error prone I imagine.
>
yes, not always cover all cases.
>> The only thing dma controller can do is avoid to execute DMAFLUSHP on its
>> own. But how about peripheral controller trigger non-multiple access? So
>> that's what I mentioned on covery letter that we should do "broken things"
>> for both dma controller and some peripherals.
>
> The other thing it could do is provide the information out via some
> internal Linux API which the drivers could query instead of directly
> having a DT property in each client driver. That way at least the DT
> only needs the quirk in one place even if the clients need to handle it
> individually.
Good idea. Thanks, Mark.
>
--
Best Regards
Shawn Lin
next prev parent reply other threads:[~2015-09-04 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 9:56 [PATCH v3 0/9] Fix broken DMAFLUSHP on Rockchips platform Shawn Lin
2015-09-01 9:56 ` [PATCH v3 1/9] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Shawn Lin
2015-09-01 9:57 ` [PATCH v3 2/9] Documentation: arm-pl330: add description of arm, pl330-broken-no-flushp Shawn Lin
2015-09-01 9:57 ` [PATCH v3 3/9] Documentation: spi-rockchip: add description of rockchip, spi-broken-burst-len Shawn Lin
2015-09-01 9:57 ` [PATCH v3 4/9] Documentation: rockchip-i2s: add description of rockchip, i2s-broken-burst-len Shawn Lin
2015-09-01 9:57 ` [PATCH v3 5/9] DMA: pl330: add quirk for broken no flushp Shawn Lin
2015-09-01 9:57 ` [PATCH v3 6/9] ARM: dts: Add arm, pl330-broken-no-flushp quirk for rk3288 platform Shawn Lin
2015-09-01 9:58 ` [PATCH v3 7/9] ARM: dts: Add arm, pl330-broken-no-flushp quirk for rk3xxx platform Shawn Lin
2015-09-01 9:58 ` [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1 Shawn Lin
2015-09-03 12:54 ` Mark Brown
2015-09-03 13:41 ` Shawn Lin
2015-09-03 17:45 ` Mark Brown
2015-09-04 0:03 ` Shawn Lin [this message]
2015-09-01 9:59 ` [PATCH v3 9/9] ASoC: rockchip_i2s: " Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E8DFCE.5040504@rock-chips.com \
--to=shawn.lin@rock-chips$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox