From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 TRIVIAL 2/2] ARM: Fix GICv2m build warning on 32 bits
Date: Fri, 04 Sep 2015 18:14:08 +0100 [thread overview]
Message-ID: <55E9D160.3090709@arm.com> (raw)
In-Reply-To: <1935621cb5eb23d740e8e49c1ab15dddcc14511c.1441373056.git.p.fedin@samsung.com>
On 04/09/15 14:29, Pavel Fedin wrote:
> After GICv2m was enabled for 32-bit ARM kernel, a warning popped up:
>
> drivers/irqchip/irq-gic-v2m.c: In function ?gicv2m_compose_msi_msg?:
> drivers/irqchip/irq-gic-v2m.c:100:2: warning: right shift count >= width
> of type [enabled by default]
> msg->address_hi = (u32) (addr >> 32);
> ^
>
> This patch fixes it by using proper macros for splitting up the value.
>
> Signed-off-by: Pavel Fedin <p.fedin@samsung•com>
> ---
> drivers/irqchip/irq-gic-v2m.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
> index fdf7065..9055b02 100644
> --- a/drivers/irqchip/irq-gic-v2m.c
> +++ b/drivers/irqchip/irq-gic-v2m.c
> @@ -97,8 +97,8 @@ static void gicv2m_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
> struct v2m_data *v2m = irq_data_get_irq_chip_data(data);
> phys_addr_t addr = v2m->res.start + V2M_MSI_SETSPI_NS;
>
> - msg->address_hi = (u32) (addr >> 32);
> - msg->address_lo = (u32) (addr);
> + msg->address_hi = upper_32_bits(addr);
> + msg->address_lo = lower_32_bits(addr);
> msg->data = data->hwirq;
> }
>
>
Reviewed-by: Marc Zyngier <marc.zyngier@arm•com>
I'll add that to my queue of GIC fixes.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2015-09-04 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 13:29 [PATCH v4 TRIVIAL 0/2] ARM: Enable GICv2m on 32-bit virt machine Pavel Fedin
2015-09-04 13:29 ` [PATCH v4 TRIVIAL 1/2] " Pavel Fedin
2015-09-04 13:29 ` [PATCH v4 TRIVIAL 2/2] ARM: Fix GICv2m build warning on 32 bits Pavel Fedin
2015-09-04 17:14 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E9D160.3090709@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox