From: slash.tmp@free•fr (Mason)
To: linux-arm-kernel@lists•infradead.org
Subject: Porting MIPS IRQ handler to ARM
Date: Fri, 04 Sep 2015 19:46:04 +0200 [thread overview]
Message-ID: <55E9D8DC.6090201@free.fr> (raw)
In-Reply-To: <yw1x8u8mxht2.fsf@unicorn.mansr.com>
On 04/09/2015 18:36, M?ns Rullg?rd wrote:
> Mason wrote:
>
>> There's just too much DT syntax that flies light-years over my head.
>> #address-cells, #size-cells, #interrupt-cells, ranges, aliases, etc.
>> Basically, all I understand is /dts-v1/;
>> (Anyone have links to good tutorials?)
>>
>> I've attached the current version I'm playing with (I tried to make it
>> as small as possible). If some charitable soul spots an obvious problem...
>> (Commented blocks have been tested uncommented, of course.)
>
> What happens when you try to boot with this device tree?
It panics in tangox_irq_init IIRC.
> Are you sure these addresses are correct? Those are the values from
> tango3.
AFAIU, that HW block hasn't changed in a long time, but I'll
double-check to be sure.
>> interrupt-parent = <&gic>;
>> interrupt-controller;
>> #address-cells = <1>;
>> #size-cells = <1>;
>>
>> irqintc: irq at 000 {
>> reg = <0x000 0x100>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> interrupts = <2>;
>
> This "interrupts" specification is wrong for a source wired into the
> GIC. For the correct format, see the binding spec in
> Documentation/devicetree/bindings/arm/gic.txt:
Doooh! I'd read that document (about 12 times) but for some
reason, it never occurred to me that I had to follow the
syntax for the intc (although that seems obvious now that
you mention it).
I suspect you've nailed my problem. Wish I could test right
away, but it'll have to wait after the weekend.
Thanks (again).
Regards.
next prev parent reply other threads:[~2015-09-04 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 16:14 Porting MIPS IRQ handler to ARM Mason
2015-09-01 16:58 ` Florian Fainelli
2015-09-02 16:25 ` Mason
2015-09-02 17:17 ` Måns Rullgård
2015-09-02 18:01 ` Mason
2015-09-04 16:13 ` Mason
2015-09-04 16:36 ` Måns Rullgård
2015-09-04 17:46 ` Mason [this message]
2015-09-04 21:49 ` Måns Rullgård
2015-09-04 16:37 ` Måns Rullgård
2015-09-04 21:20 ` Matthias Brugger
2015-09-01 17:07 ` Måns Rullgård
2015-09-01 17:57 ` Mason
2015-09-01 18:07 ` Florian Fainelli
2015-09-01 19:01 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E9D8DC.6090201@free.fr \
--to=slash.tmp@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox