From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest")
Date: Wed, 16 Sep 2015 18:16:50 +0100 [thread overview]
Message-ID: <55F9A402.1060408@arm.com> (raw)
In-Reply-To: <20150917011021.0460792d@xhacker>
On 16/09/15 18:10, Jisheng Zhang wrote:
> Dear Thomas,
>
> On Thu, 17 Sep 2015 00:59:08 +0800
> Jisheng Zhang <jszhang@marvell•com> wrote:
>
>> On Wed, 16 Sep 2015 18:52:41 +0200
>> Thomas Gleixner <tglx@linutronix•de> wrote:
>>
>>> On Thu, 17 Sep 2015, Jisheng Zhang wrote:
>>>
>>>> Hi Marc,
>>>>
>>>> Commit 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a
>>>> guest") causes a regression on Marvell BG4CT SoC. In this SoC, there's only one
>>>> GIC, the secondary irq controller is Synopsys DW iCtl:
>>>> drivers/irqchip/irq-dw-apb-ictl.c
>>>>
>>>> So cascading_gic_irq() should return true on Marvell BG4CT SoC, but it returns
>>>> false. The logic in cascading_gic_irq() doesn't take cascaded irq controller
>>>> which is provided by non-gic controllers.
>>>
>>> I have a fix pending for this in
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.irq
>>>
>>> 714665351cc7: irqchip/gic: Use IRQD_FORWARDED_TO_VCPU flag
>>>
>>> Can you please give that a try?
>>
>> Sure, Will try and get back to you
>
> Good news! The regression is fixed, cascaded irq works again!
>
> Feel free to add
>
> Tested-by: Jisheng Zhang <jszhang@marvell•com>
Ah, excellent. Probably a case of handler_data being reused... Thanks a
lot for testing this!
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2015-09-16 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 16:32 Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") Jisheng Zhang
2015-09-16 16:43 ` Jisheng Zhang
2015-09-16 16:55 ` Marc Zyngier
2015-09-16 16:52 ` Thomas Gleixner
2015-09-16 16:59 ` Jisheng Zhang
2015-09-16 17:10 ` Jisheng Zhang
2015-09-16 17:16 ` Marc Zyngier [this message]
2015-09-17 20:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F9A402.1060408@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox