public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: j.anaszewski@samsung•com (Jacek Anaszewski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/4] s5p-jpeg: add support for 5433
Date: Fri, 18 Sep 2015 16:30:08 +0200	[thread overview]
Message-ID: <55FC1FF0.7080506@samsung.com> (raw)
In-Reply-To: <1442586060-23657-3-git-send-email-andrzej.p@samsung.com>

Hi Andrzej,

On 09/18/2015 04:20 PM, Andrzej Pietrasiewicz wrote:
> JPEG IP found in Exynos5433 is similar to what is in Exynos4, but
> there are some subtle differences which this patch takes into account.
>
> The most important difference is in what is processed by the JPEG IP and
> what has to be provided to it. In case of 5433 the IP does not parse
> Huffman and quantisation tables, so this has to be performed with the CPU
> and the majority of the code in this patch does that.
>
> A small but important difference is in what address is passed to the JPEG
> IP. In case of 5433 it is the SOS (start of scan) position, which is
> natural, because the headers must be parsed elsewhere.
>
> There is also a difference in how the hardware is put to work in
> device_run.
>
> Data structures are extended as appropriate to accommodate the above
> changes.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung•com>
> ---
>   .../bindings/media/exynos-jpeg-codec.txt           |   3 +-
>   drivers/media/platform/s5p-jpeg/jpeg-core.c        | 378 +++++++++++++++++++--
>   drivers/media/platform/s5p-jpeg/jpeg-core.h        |  31 ++
>   drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c  |  80 ++++-
>   drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.h  |  11 +-
>   drivers/media/platform/s5p-jpeg/jpeg-regs.h        |  85 +++--
>   6 files changed, 522 insertions(+), 66 deletions(-)

Reviewed-by: Jacek Anaszewski <j.anaszewski@samsung•com>

-- 
Best Regards,
Jacek Anaszewski

  reply	other threads:[~2015-09-18 14:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 14:20 [PATCH 0/4] Exynos 5433 jpeg h/w codec support Andrzej Pietrasiewicz
2015-09-18 14:20 ` [PATCH 1/4] s5p-jpeg: generalize clocks handling Andrzej Pietrasiewicz
2015-09-18 14:29   ` Jacek Anaszewski
2015-09-18 14:20 ` [PATCH 2/4] s5p-jpeg: add support for 5433 Andrzej Pietrasiewicz
2015-09-18 14:30   ` Jacek Anaszewski [this message]
2015-09-18 14:20 ` [PATCH 3/4] MAINTAINERS: add exynos jpeg codec maintainers Andrzej Pietrasiewicz
2015-09-18 14:30   ` Jacek Anaszewski
2015-09-18 14:21 ` [PATCH 4/4] ARM64: dts: exynos5433: add jpeg node Andrzej Pietrasiewicz
2015-09-21  9:50   ` Hans Verkuil
2015-09-21  9:59     ` Andrzej Pietrasiewicz
2015-09-21 11:41       ` Mauro Carvalho Chehab
2015-09-21 12:28         ` Sylwester Nawrocki
2015-09-21 12:55         ` Andrzej Pietrasiewicz
2015-09-28  8:52       ` Krzysztof Kozlowski
2015-09-28 11:54         ` Bartlomiej Zolnierkiewicz
2015-09-28 12:02           ` Krzysztof Kozlowski
2015-09-30  6:35             ` Kukjin Kim
2015-09-30  6:46               ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FC1FF0.7080506@samsung.com \
    --to=j.anaszewski@samsung$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox