From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] spi: atmel: remove warning when !CONFIG_PM_SLEEP
Date: Fri, 18 Sep 2015 16:34:34 +0200 [thread overview]
Message-ID: <55FC20FA.1000405@atmel.com> (raw)
In-Reply-To: <1441873192-18511-1-git-send-email-alexandre.belloni@free-electrons.com>
Le 10/09/2015 10:19, Alexandre Belloni a ?crit :
> When CONFIG_PM is defined but not CONFIG_PM_SLEEP (this happens when
> CONFIG_SUSPEND is not defined), there is the following warning:
>
> drivers/spi/spi-atmel.c:1723:12: warning: ?atmel_spi_suspend? defined but not used [-Wunused-function]
> drivers/spi/spi-atmel.c:1741:12: warning: ?atmel_spi_resume? defined but not used [-Wunused-function]
>
> Enclose both atmel_spi_suspend and atmel_spi_resume in #ifdef
> CONFIG_PM_SLEEP/#endif to solve that.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons•com>
No problem on my side:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel•com>
> ---
> drivers/spi/spi-atmel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index bf9ed380bb1c..63318e2afba1 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1720,6 +1720,7 @@ static int atmel_spi_runtime_resume(struct device *dev)
> return clk_prepare_enable(as->clk);
> }
>
> +#ifdef CONFIG_PM_SLEEP
> static int atmel_spi_suspend(struct device *dev)
> {
> struct spi_master *master = dev_get_drvdata(dev);
> @@ -1756,6 +1757,7 @@ static int atmel_spi_resume(struct device *dev)
>
> return ret;
> }
> +#endif
>
> static const struct dev_pm_ops atmel_spi_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(atmel_spi_suspend, atmel_spi_resume)
>
--
Nicolas Ferre
prev parent reply other threads:[~2015-09-18 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 8:19 [PATCH] spi: atmel: remove warning when !CONFIG_PM_SLEEP Alexandre Belloni
2015-09-18 14:34 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC20FA.1000405@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox