Subject: [PATCH v2 1/9] ARM: dts: consolidate aliases for Cygnus dt files

From: [email-masked] (Ray Jui)
Date: Fri, 18 Sep 2015 14:44:54 -0700

On 9/18/2015 2:27 PM, Arnd Bergmann wrote:
> On Friday 18 September 2015 14:24:06 Ray Jui wrote:
>> Move aliases into bcm-cygnus.dtsi to avoid duplications in Cygnus dts
>> files
>>
> 
> We generally recommend keeping them separate:
> 
>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> index e1ac07a..30903ba 100644
>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> @@ -40,6 +40,10 @@
>>         model = "Broadcom Cygnus SoC";
>>         interrupt-parent = <&gic>;
>>  
>> +       aliases {
>> +               serial0 = &uart3;
>> +       };
>> +
> 
> The SoC has at least four uarts according to this, so it seems unlikely that
> each board really only uses only the fourth one of them and labels it '0'
> on the board. As soon as you get one board that has more than one uart wired
> up, you would need to undo this.
> 
> 	Arnd
> 

I think Scott might have explained this in the past. uart3 is going to
be used on all Cygnus boards (including all future boards) because the
bootrom was designed to use uart3 as console and that won't change.

Let me know if you still think I need to move this back to the dts.

Thanks,

Ray