From: josh.wu@atmel•com (Josh Wu)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: at91/dt: ov2640: add hsync/vsync-active property
Date: Mon, 21 Sep 2015 09:19:48 +0800 [thread overview]
Message-ID: <55FF5B34.8040500@atmel.com> (raw)
In-Reply-To: <55FC1B12.8000703@atmel.com>
Hi, Nicolas
On 9/18/2015 10:09 PM, Nicolas Ferre wrote:
> Le 18/09/2015 13:28, Josh Wu a ?crit :
>> On at91sam9x5ek/at91sam9m10g45ek/sama5d3xek boards, we use the parallel
>> connection for ov2640. So we must set the hsync/vsync property (1 means
>> active high).
>> Otherwise, the connection would be seen as BT.656 or BT.1120.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel•com>
> Hi Josh,
>
> Does this patch apply because of the new enhancement that you had
> proposed in "media: atmel-isi: parse the DT parameters for
> vsync/hsync/pixclock polarity" or does it apply even before?
> Is it a fix that applies to older kernels?
It's is a fix, according to the dt binding of video interface.
So it should be applied before:
"media: atmel-isi: parse the DT parameters for
vsync/hsync/pixclock polarity".
it has no impact in older kernel as the driver doesn't parse that
property yet.
>
> So, should I wait for the enhancements to enter media git tree or can I
> take them anyway?
yes, you can take it without waiting for the media tree. Thanks.
Best Regards,
Josh Wu
>
> Bye,
>
>> ---
>>
>> arch/arm/boot/dts/at91sam9m10g45ek.dts | 2 ++
>> arch/arm/boot/dts/at91sam9x5ek.dtsi | 2 ++
>> arch/arm/boot/dts/sama5d3xmb.dtsi | 2 ++
>> 3 files changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/dts/at91sam9m10g45ek.dts
>> index d1ae60a..9d16ef8 100644
>> --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts
>> +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts
>> @@ -198,6 +198,8 @@
>> isi_0: endpoint {
>> remote-endpoint = <&ov2640_0>;
>> bus-width = <8>;
>> + vsync-active = <1>;
>> + hsync-active = <1>;
>> };
>> };
>> };
>> diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi
>> index d237c46..479f200 100644
>> --- a/arch/arm/boot/dts/at91sam9x5ek.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5ek.dtsi
>> @@ -66,6 +66,8 @@
>> isi_0: endpoint at 0 {
>> remote-endpoint = <&ov2640_0>;
>> bus-width = <8>;
>> + vsync-active = <1>;
>> + hsync-active = <1>;
>> };
>> };
>> };
>> diff --git a/arch/arm/boot/dts/sama5d3xmb.dtsi b/arch/arm/boot/dts/sama5d3xmb.dtsi
>> index 83bee7a..8901042 100644
>> --- a/arch/arm/boot/dts/sama5d3xmb.dtsi
>> +++ b/arch/arm/boot/dts/sama5d3xmb.dtsi
>> @@ -87,6 +87,8 @@
>> isi_0: endpoint {
>> remote-endpoint = <&ov2640_0>;
>> bus-width = <8>;
>> + vsync-active = <1>;
>> + hsync-active = <1>;
>> };
>> };
>> };
>>
>
next prev parent reply other threads:[~2015-09-21 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 11:28 [PATCH] ARM: at91/dt: ov2640: add hsync/vsync-active property Josh Wu
2015-09-18 14:09 ` Nicolas Ferre
2015-09-21 1:19 ` Josh Wu [this message]
2015-09-21 14:20 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FF5B34.8040500@atmel.com \
--to=josh.wu@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox