From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] clk: bcm2835: Add a driver for the auxiliary peripheral clock gates.
Date: Mon, 21 Sep 2015 19:11:38 -0700 [thread overview]
Message-ID: <5600B8DA.4030406@wwwdotorg.org> (raw)
In-Reply-To: <1441923750-19404-3-git-send-email-eric@anholt.net>
On 09/10/2015 03:22 PM, Eric Anholt wrote:
> There are a pair of SPI masters and a mini UART that were last minute
> additions. As a result, they didn't get integrated in the same way as
> the other gates off of the VPU clock in CPRMAN.
> diff --git a/drivers/clk/bcm/clk-bcm2835-aux.c b/drivers/clk/bcm/clk-bcm2835-aux.c
> +static int bcm2835_aux_clk_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct clk_onecell_data *onecell;
> + const char *parent;
> + struct clk *parent_clk;
> + void __iomem *reg;
> +
> + parent_clk = of_clk_get(dev->of_node, 0);
> + if (IS_ERR(parent_clk))
> + return PTR_ERR(parent_clk);
> + parent = __clk_get_name(parent_clk);
I think all the comments I made on probe() for the main bcm2835 clock
driver likely apply here too.
Also, is it "legal" for clock drivers to use __clk_get_name()? I thought
that was a clock core internal function, but may be wrong. I would have
expected to be able to pass a clock object when registering clocks
rather than a clock name, but oh well.
BTW, I like how this series shows how useful it is for someone with full
knowledge of the HW to come up with the DT bindings for a HW module;
once you know how the HW is actually designed, the correct binding ends
up being a lot easier to come up with, rather than guessing:-)
next prev parent reply other threads:[~2015-09-22 2:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 22:22 BCM2835 auxiliary peripheral clocks Eric Anholt
2015-09-10 22:22 ` [PATCH 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates Eric Anholt
2015-09-10 22:22 ` [PATCH 2/3] clk: bcm2835: Add a driver " Eric Anholt
2015-09-11 10:24 ` Martin Sperl
2015-09-22 2:11 ` Stephen Warren [this message]
2015-10-02 0:19 ` Stephen Boyd
2015-09-10 22:22 ` [PATCH 3/3] ARM: bcm2835: Add the auxiliary clocks to the device tree Eric Anholt
2015-09-22 2:12 ` Stephen Warren
2015-09-22 2:19 ` Stephen Warren
2015-09-28 19:26 ` Eric Anholt
2015-09-28 19:49 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5600B8DA.4030406@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox