public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: icenowy@aosc•xyz (Icenowy Zheng)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino
Date: Wed, 27 Jul 2016 10:38:10 +0800	[thread overview]
Message-ID: <5601469587090@web14m.yandex.ru> (raw)
In-Reply-To: <20160726153352.GH7190@lukather>



26.07.2016, 23:38, "Maxime Ripard" <maxime.ripard@free-electrons•com>:
> Hi Stefan,
>
> On Mon, Jul 25, 2016 at 03:37:23PM +0300, Stefan Mavrodiev wrote:
>> ?A33-OLinuXino is A33 development board designed by Olimex LTD.
>>
>> ?It has AXP233 PMU, 1GB DRAM, a micro SD card, one USB-OTG connector,
>> ?headphone and mic jacks, connector for LiPo battery and optional
>> ?4GB NAND Flash.
>>
>> ?It has two 40-pin headers. One for LCD panel, and one for
>> ?additional modules. Also there is CSI/DSI connector.
>>
>> ?Signed-off-by: Stefan Mavrodiev <stefan.mavrodiev@gmail•com>
>
> It looks mostly good, a few comments though.
>> ?+&pio {
>> ?+ led_pin_olinuxino: led_pins at 0 {
>> ?+ allwinner,pins = "PB7";
>> ?+ allwinner,function = "gpio_out";
>
> This line is not properly indented.
>
>> ?+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> ?+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> ?+ };
>
> And this one too.
>
>> ?+&reg_dc1sw {
>> ?+ regulator-name = "vcc-lcd";
>> ?+};
>
> No constraints on this one?
The "regulator" dc1sw is, in fact, a switch (so it's named as "sw").
So it have only on-off status.

The constraints in dc1sw has prevented one of my A31s tablet from booting
when it's not removed.
>
>> ?+&reg_dcdc1 {
>> ?+ regulator-always-on;
>> ?+ regulator-min-microvolt = <3300000>;
>> ?+ regulator-max-microvolt = <3300000>;
>> ?+ regulator-name = "vcc-dsi";
>> ?+};
>
> What is it used for? Is it really necessary to keep it on at all time?
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> ,
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2016-07-27  2:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 12:37 [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino Stefan Mavrodiev
2016-07-26 15:33 ` Maxime Ripard
2016-07-27  2:38   ` Icenowy Zheng [this message]
2016-07-27  5:12   ` stefan.mavrodiev at gmail.com
2016-07-27  6:21     ` Maxime Ripard
2016-07-27 10:02       ` stefan.mavrodiev at gmail.com
2016-07-28 17:53         ` Maxime Ripard
2016-08-15  7:36           ` [PATCH v5] " Stefan Mavrodiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5601469587090@web14m.yandex.ru \
    --to=icenowy@aosc$(echo .)xyz \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox