From: sudeep.holla@arm•com (Sudeep Holla)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND
Date: Wed, 23 Sep 2015 10:44:07 +0100 [thread overview]
Message-ID: <56027467.1020803@arm.com> (raw)
In-Reply-To: <20150922210322.GA3442@x1>
On 22/09/15 22:03, Lee Jones wrote:
> On Tue, 22 Sep 2015, Sudeep Holla wrote:
>> On 22/09/15 00:20, Lee Jones wrote:
>>> On Mon, 21 Sep 2015, Sudeep Holla wrote:
>>>
>>>> The IRQF_NO_SUSPEND flag is used to identify the interrupts that should
>>>> be left enabled so as to allow them to work as expected during the
>>>> suspend-resume cycle, but doesn't guarantee that it will wake the system
>>> >from a suspended state, enable_irq_wake is recommended to be used for
>>>> the wakeup.
>>>>
>>>> This patch removes the use of IRQF_NO_SUSPEND flags replacing it with
>>>> enable_irq_wake instead.
>>>>
>>>> Cc: Linus Walleij <linus.walleij@linaro•org>
>>>> Cc: linux-arm-kernel at lists.infradead.org
>>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm•com>
>>>> ---
>>>> drivers/mfd/ab8500-core.c | 11 +++++++++--
>>>> drivers/mfd/ab8500-debugfs.c | 2 +-
>>>> drivers/mfd/ab8500-gpadc.c | 15 +++++++++++----
>>>> drivers/mfd/db8500-prcmu.c | 24 +++++++++++++++++-------
>>>> drivers/power/ab8500_btemp.c | 6 ++++--
>>>> drivers/power/ab8500_charger.c | 6 ++++--
>>>> drivers/power/ab8500_fg.c | 9 ++++++---
>>>> drivers/thermal/db8500_thermal.c | 5 ++---
>>>> drivers/usb/phy/phy-ab8500-usb.c | 10 ++++++----
>>>> 9 files changed, 60 insertions(+), 28 deletions(-)
>>>
>>> Is there a reason for bundling the changes in all of these subsystems
>>> together into a single patch?
>>>
>>
>> No, I understand this needs to be split. Since I was not 100% confident
>> about this change, I wanted LinusW to review and provide feedback and
>> gets things working before I can split this changes. I must have added
>> RFC, but usually it gets ignored :)
>
> Best if Linus reviews the correct patch-set. Please split and
> resubmit.
>
Sure, but would like to get some feedback before I proceed just to
ensure my understanding is correct.
Regards,
Sudeep
prev parent reply other threads:[~2015-09-23 9:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442850433-5903-1-git-send-email-sudeep.holla@arm.com>
2015-09-21 15:47 ` [PATCH 10/17] tty/serial: st-asc: drop the use of IRQF_NO_SUSPEND Sudeep Holla
2015-09-21 15:47 ` [PATCH 12/17] ARM: OMAP2+: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2015-10-12 20:20 ` Tony Lindgren
2015-10-12 20:28 ` Tony Lindgren
2015-10-13 10:42 ` Sudeep Holla
2015-10-13 14:53 ` Tony Lindgren
2015-10-13 15:20 ` Sudeep Holla
2015-09-21 15:47 ` [PATCH 14/17] media: st-rc: " Sudeep Holla
2015-10-19 17:40 ` Sudeep Holla
2015-09-21 15:47 ` [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Sudeep Holla
2015-09-21 23:20 ` Lee Jones
2015-09-22 10:04 ` Sudeep Holla
2015-09-22 21:03 ` Lee Jones
2015-09-23 9:44 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56027467.1020803@arm.com \
--to=sudeep.holla@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox