From: slash.tmp@free•fr (Mason)
To: linux-arm-kernel@lists•infradead.org
Subject: Steps to submit a new arch/arm port
Date: Fri, 25 Sep 2015 18:09:50 +0200 [thread overview]
Message-ID: <560571CE.1000304@free.fr> (raw)
In-Reply-To: <8912441.4NjM1sFKRe@wuerfel>
On 25/09/2015 17:52, Arnd Bergmann wrote:
> On Friday 25 September 2015 17:28:54 Mason wrote:
>> On 25/09/2015 16:11, Arnd Bergmann wrote:
>>> On Friday 25 September 2015 15:35:36 Mason wrote:
>>>>
>>>> So 'default y' enables ARCH_TANGO4 only if ARCH_TANGOX is selected,
>>>> right?
>>>
>>> You should really only have one of the two.
>>
>> I plan to add ARCH_TANGO5 in a few weeks. So I copied the layout used
>> by Samsung for EXYNOSx and TI for OMAPx.
>
> Better start simple, I wouldn't expect there to be too much code
> that is specific to just one of them to warrant a top-level Kconfig
> option like on OMAP.
I don't understand. If I create only ARCH_TANGO4, then I'll have to
move everything around when ARCH_TANGO5 shows up... <confused>
>>>> It will build, but it won't run! My port uses the TWD for clockevents,
>>>> and smp_twd.c is only compiled if HAVE_ARM_TWD. So I must set SMP.
>>>
>>> I think this has come up before and should be fixed. Could you
>>> send a patch that allows using TWD in uniprocessor configurations?
>>
>> This was discussed here:
>> http://thread.gmane.org/gmane.linux.ports.arm.kernel/389931/focus=15737
>>
>> I can re-post the same patch.
>
> Yes, please include that patch in the series.
Just to be sure, we are talking about this patch:
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 1c5021002fe4..774dc59650c5 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1407,7 +1407,6 @@ config HAVE_ARM_ARCH_TIMER
config HAVE_ARM_TWD
bool
- depends on SMP
select CLKSRC_OF if OF
help
This options enables support for the ARM timer and watchdog unit
diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
index 172c6a05d27f..877c1d5ec942 100644
--- a/arch/arm/kernel/smp_twd.c
+++ b/arch/arm/kernel/smp_twd.c
@@ -388,9 +388,6 @@ static void __init twd_local_timer_of_register(struct device_node *np)
{
int err;
- if (!is_smp() || !setup_max_cpus)
- return;
-
twd_ppi = irq_of_parse_and_map(np, 0);
if (!twd_ppi) {
err = -EINVAL;
Regards.
next prev parent reply other threads:[~2015-09-25 16:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 15:00 Steps to submit a new arch/arm port Mason
2015-09-21 15:49 ` Arnd Bergmann
2015-09-22 14:36 ` Mason
2015-09-22 14:51 ` Arnd Bergmann
2015-09-22 14:56 ` Russell King - ARM Linux
2015-09-22 15:54 ` Mason
2015-09-22 16:29 ` Russell King - ARM Linux
2015-09-23 8:49 ` Mason
2015-09-23 9:13 ` Russell King - ARM Linux
2015-09-23 9:21 ` Mason
2015-09-23 9:26 ` Russell King - ARM Linux
2015-09-22 19:15 ` Arnd Bergmann
2015-09-23 9:26 ` Mason
2015-09-23 9:34 ` Arnd Bergmann
2015-09-25 13:06 ` Mason
2015-09-25 13:17 ` Arnd Bergmann
2015-09-25 13:35 ` Mason
2015-09-25 14:11 ` Arnd Bergmann
2015-09-25 15:28 ` Mason
2015-09-25 15:33 ` Mason
2015-09-25 15:49 ` Arnd Bergmann
2015-09-25 15:52 ` Arnd Bergmann
2015-09-25 16:09 ` Mason [this message]
2015-09-25 17:20 ` Arnd Bergmann
2015-09-28 13:48 ` Mason
2015-09-28 14:43 ` Måns Rullgård
2015-09-28 16:32 ` Mason
2015-09-28 17:29 ` Russell King - ARM Linux
2015-09-22 15:48 ` Måns Rullgård
2015-09-25 9:27 ` Mason
2015-09-25 9:46 ` Javier Martinez Canillas
2015-09-25 11:56 ` Arnd Bergmann
2015-09-25 12:06 ` Russell King - ARM Linux
2015-09-21 15:51 ` Måns Rullgård
2015-09-21 16:13 ` Russell King - ARM Linux
2015-09-22 16:08 ` Mason
2015-09-22 16:24 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560571CE.1000304@free.fr \
--to=slash.tmp@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox