From: icenowy@aosc•xyz (Icenowy Zheng)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 08/10] dmaengine: sun6i: allow build on ARM64 platforms (sun50i)
Date: Thu, 02 Feb 2017 23:50:42 +0800 [thread overview]
Message-ID: <5605761486050642@web3m.yandex.ru> (raw)
In-Reply-To: <20170131033236.GH19244@localhost>
31.01.2017, 11:32, "Vinod Koul" <vinod.koul@intel•com>:
> On Tue, Jan 31, 2017 at 02:23:55AM +0800, Icenowy Zheng wrote:
>> ?31.01.2017, 00:41, "Vinod Koul" <vinod.koul@intel•com>:
>> ?> On Sun, Jan 29, 2017 at 10:33:29AM +0800, Icenowy Zheng wrote:
>> ?>> ?As 64-bit Allwinner H5 SoC has the same DMA engine with H3, the DMA
>> ?>> ?driver should be allowed to be built for ARM64, in order to make it work on H5.
>> ?>>
>> ?>> ?Signed-off-by: Icenowy Zheng <icenowy@aosc•xyz>
>> ?>> ?Acked-by: Maxime Ripard <maxime.ripard@free-electrons•com>
>> ?>> ?Acked-by: Chen-Yu Tsai <wens@csie•org>
>> ?>> ?---
>> ?>> ?Patch introduced between v1 and v2, to satisfy the newly added H3/H5 audio
>> ?>> ?codec support.
>> ?>>
>> ?>> ??drivers/dma/Kconfig | 2 +-
>> ?>> ??1 file changed, 1 insertion(+), 1 deletion(-)
>> ?>>
>> ?>> ?diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
>> ?>> ?index 0d6a96ee9fc7..d01d59812cf3 100644
>> ?>> ?--- a/drivers/dma/Kconfig
>> ?>> ?+++ b/drivers/dma/Kconfig
>> ?>> ?@@ -157,7 +157,7 @@ config DMA_SUN4I
>> ?>>
>> ?>> ??config DMA_SUN6I
>> ?>> ??????????tristate "Allwinner A31 SoCs DMA support"
>> ?>> ?- depends on MACH_SUN6I || MACH_SUN8I || COMPILE_TEST
>> ?>> ?+ depends on MACH_SUN6I || MACH_SUN8I || (ARM64 && ARCH_SUNXI) || COMPILE_TEST
>> ?>
>> ?> Do we really need ARM64 here? also looking at others I wonder why isn't
>> ?> this MACH_SUNXI...?
>>
>> ?You mean directly place "ARCH_SUNXI" here?
>>
>> ?SUN4I/SUN5I/SUN7I do not use DMA_SUN6I, they have different DMA
>> ?controllers.
>
> No my question was different..
>
> We have MACH_SUNxx for 6I and 8I, so why do we have ARCH_SUNXI and if its an
> arch SUNXI, X means it can take any value...
>
> This schema looks pretty confusing while reading
It's a weird schema made by the vendor.
> Also I had a question on usage of ARM64..
For ARM64, we have no MACH_SUN50I, as the only ARM64-capable series in SUNXI
is SUN50I. So I use (ARM64 && ARCH_SUNXI) here to represent "MACH_SUN50I".
P.S. Allwinner have sun4i(A10), sun5i(A13/A10s/GR8), sun6i(A31/A31s), sun7i(A20),
sun8i(A23/A33/H3/V3s/A83T), sun9i(A80), sun50i(A64/H5). From the sun6i
generation, things changed a lot; however, sun7i is a derivation of sun4i. In U-Boot,
every SoC after sun6i (except sun7i) have an option CONFIG_GEN_SUN6I.
This DMAengine driver is for the new generation DMA engine.
SUN4I, SUN5I and SUN7I have no hardware that uses such a DMAengine, so here's
MACH_SUN6I || MACH_SUN8I || (ARM64 && ARCH_SUNXI), to prevent it to be built
in a kernel that do not support any system with such a DMAengine.
>
> --
> ~Vinod
next prev parent reply other threads:[~2017-02-02 15:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 2:33 [PATCH v3 00/10] Allwinner H5 and Orange Pi PC2 support Icenowy Zheng
2017-01-29 2:33 ` [PATCH v3 01/10] drivers: pinctrl: add driver for Allwinner H5 SoC Icenowy Zheng
2017-01-30 15:23 ` Linus Walleij
2017-01-29 2:33 ` [PATCH v3 02/10] arm64: allwinner: Kconfig: add essential pinctrl driver for H5 Icenowy Zheng
2017-01-29 2:33 ` [PATCH v3 03/10] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5 Icenowy Zheng
2017-01-30 9:03 ` Maxime Ripard
2017-01-29 2:33 ` [PATCH v3 04/10] clk: sunxi-ng: add support for Allwinner H5 SoC Icenowy Zheng
2017-01-30 9:04 ` Maxime Ripard
2017-01-29 2:33 ` [PATCH v3 05/10] arm: dts: sun8i: split Allwinner H3 .dtsi Icenowy Zheng
2017-01-30 1:42 ` André Przywara
2017-01-30 9:09 ` Maxime Ripard
2017-01-30 9:06 ` Maxime Ripard
2017-01-29 2:33 ` [PATCH v3 06/10] clk: sunxi-ng: remove transitional headers for dt-bindings Icenowy Zheng
2017-01-30 9:09 ` Maxime Ripard
2017-01-29 2:33 ` [PATCH v3 07/10] arm64: dts: allwinner: add Allwinner H5 .dtsi Icenowy Zheng
2017-01-29 2:33 ` [PATCH v3 08/10] dmaengine: sun6i: allow build on ARM64 platforms (sun50i) Icenowy Zheng
2017-01-30 16:42 ` Vinod Koul
2017-01-30 18:23 ` Icenowy Zheng
2017-01-31 3:32 ` Vinod Koul
2017-02-02 15:50 ` Icenowy Zheng [this message]
2017-02-05 7:19 ` Vinod Koul
2017-01-29 2:33 ` [PATCH v3 09/10] ASoC: sunxi: allow the analog codec driver to be built on ARM64 Icenowy Zheng
2017-01-29 2:33 ` [PATCH v3 10/10] arm64: dts: sunxi: add support for the Orange Pi PC 2 board Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5605761486050642@web3m.yandex.ru \
--to=icenowy@aosc$(echo .)xyz \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox