Subject: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings

From: [email-masked] (Wu, Songjun)
Date: Tue, 29 Sep 2015 09:42:14 +0800

On 9/28/2015 19:26, Peter Korsgaard wrote:
>>>>>> "kbuild" == kbuild test robot <[email-masked]> writes:
>
>   > sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579
>   >  PTR_ERR should access the value just tested by IS_ERR
>
>   > Semantic patch information:
>   >  There can be false positives in the patch case, where it is the call
>   >  IS_ERR that is wrong.
>
>   > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
>   > CC: Songjun Wu <[email-masked]>
>   > Signed-off-by: Fengguang Wu <[email-masked]>
>   > ---
>
>   >  atmel-classd.c |    2 +-
>   >  1 file changed, 1 insertion(+), 1 deletion(-)
>
>   > --- a/sound/soc/atmel/atmel-classd.c
>   > +++ b/sound/soc/atmel/atmel-classd.c
>   > @@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla
>
>   dd-> gclk = devm_clk_get(dev, "gclk");
>   >  	if (IS_ERR(dd->aclk)) {
>   > -		ret = PTR_ERR(dd->gclk);
>   > +		ret = PTR_ERR(dd->aclk);
>
> It looks like it is the other way around. It should test
> IS_ERR(dd->gclk) instead.
>
Thank you, you are right.
It should test IS_ERR(dd->gclk) instead.