public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v9 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs
Date: Tue, 29 Sep 2015 17:43:10 +0300	[thread overview]
Message-ID: <560AA37E.2090106@cogentembedded.com> (raw)
In-Reply-To: <1443495698-32233-2-git-send-email-chunfeng.yun@mediatek.com>

Hello.

On 09/29/2015 06:01 AM, Chunfeng Yun wrote:

> add a DT binding documentation of usb3.0 phy for MT65xx
> SoCs from Mediatek.
>
> Acked-by: Rob Herring <robh@kernel•org>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek•com>
> ---
>   .../devicetree/bindings/phy/phy-mt65xx-usb.txt     | 68 ++++++++++++++++++++++
>   1 file changed, 68 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt b/Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt
> new file mode 100644
> index 0000000..00100cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt
> @@ -0,0 +1,68 @@
> +mt65xx USB3.0 PHY binding
> +--------------------------
> +
> +This binding describes a usb3.0 phy for mt65xx platforms of Medaitek SoC.
> +
> +Required properties (controller (parent) node):
> + - compatible	: should be "mediatek,mt8173-u3phy"
> + - reg		: offset and length of register for phy, exclude port's
> +		  register.
> + - clocks	: a list of phandle + clock-specifier pairs, one for each
> +		  entry in clock-names
> + - clock-names	: must contain
> +		  "u3phya_ref": for reference clock of usb3.0 analog phy.
> +
> +Required nodes	: a sub-node is required for each port the controller
> +		  provides. Address range information including the usual
> +		  'reg' property is used inside these nodes to describe
> +		  the controller's topology.
> +
> +Required properties (port (child) node):
> +- reg		: address and length of the register set for the port.
> +- #phy-cells	: should be 1 (See second example)
> +		  cell after port phandle is phy type from:
> +			- PHY_TYPE_USB2
> +			- PHY_TYPE_USB3
> +
> +Example:
> +
> +u3phy: usb-phy at 11290000 {
> +	compatible = "mediatek,mt8173-u3phy";
> +	reg = <0 0x11290000 0 0x800>;
> +	clocks = <&apmixedsys CLK_APMIXED_REF2USB_TX>;
> +	clock-names = "u3phya_ref";
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +	ranges;

    You don't describe the above 3 props neither as mandatory nor optional.

[...]
> +Specifying phy control of devices
> +---------------------------------
> +
> +Device nodes should specify the configuration required in their "phys"
> +property, containing a phandle to the phy port node and a device type;
> +phy-names for each port are optional.
> +
> +Example:
> +
> +#include <dt-bindings/phy/phy.h>
> +
> +usb30: usb at 11270000 {
> +	...
> +	phys = <&phy_port0 PHY_TYPE_USB3>;
> +	phy-names = "usb3-0";
> +	...
> +};

    Isn't the above already described in 
Documentation/devicetree/bindings/phy/phy-bindings.txt?

MBR, Sergei

  reply	other threads:[~2015-09-29 14:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29  3:01 [PATCH v9 0/5] Mediatek xHCI support Chunfeng Yun
2015-09-29  3:01 ` [PATCH v9 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs Chunfeng Yun
2015-09-29 14:43   ` Sergei Shtylyov [this message]
2015-10-08 11:27     ` chunfeng yun
2015-09-29  3:01 ` [PATCH v9 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller Chunfeng Yun
2015-09-29 14:49   ` Sergei Shtylyov
2015-10-08 11:37     ` chunfeng yun
2015-09-29  3:01 ` [PATCH v9 3/5] phy: add usb3.0 phy driver for mt65xx SoCs Chunfeng Yun
2015-10-06 14:20   ` Kishon Vijay Abraham I
2015-10-08 11:45     ` chunfeng yun
2015-09-29  3:01 ` [PATCH v9 4/5] xhci: mediatek: support MTK xHCI host controller Chunfeng Yun
2015-10-01 11:44   ` Daniel Thompson
2015-10-08 12:05     ` chunfeng yun
2015-10-08 12:28       ` Daniel Thompson
2015-10-08 13:05         ` Mathias Nyman
2015-10-08 14:42           ` chunfeng yun
2015-10-08 14:38         ` chunfeng yun
2015-10-15 14:46   ` Mathias Nyman
2015-10-18  1:25     ` chunfeng yun
2015-10-19 11:25       ` Mathias Nyman
2015-10-20  6:29         ` chunfeng yun
2015-10-20  8:25           ` Mathias Nyman
2015-09-29  3:01 ` [PATCH v9 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 Chunfeng Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560AA37E.2090106@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox