From: jc@eclis•ch (Jean-Christian de Rivaz)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.
Date: Tue, 29 Sep 2015 22:59:46 +0200 [thread overview]
Message-ID: <560AFBC2.5050000@eclis.ch> (raw)
In-Reply-To: <20150929203554.GH3982@pengutronix.de>
Le 29. 09. 15 22:35, Uwe Kleine-K?nig a ?crit :
> Hello,
>
> On Tue, Sep 29, 2015 at 10:03:07PM +0200, jc at eclis.ch wrote:
>> From: Jean-Christian de Rivaz <jc@eclis•ch>
>>
>> According to Russell King:
>> In any case, unless you have a Marvell platform, you should have this
>> disabled - it provides a performance boost for Marvell platforms, but
>> degrades performance everywhere else. Please ensure that you disable
>> CONFIG_UACCESS_WITH_MEMCPY.
>>
>> Signed-off-by: Jean-Christian de Rivaz <jc@eclis•ch>
>> ---
>> arch/arm/configs/at91_dt_defconfig | 2 +-
>> arch/arm/configs/sama5_defconfig | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
>> index 090c5b2..1807d7f 100644
>> --- a/arch/arm/configs/at91_dt_defconfig
>> +++ b/arch/arm/configs/at91_dt_defconfig
>> @@ -21,7 +21,7 @@ CONFIG_SOC_SAM_V4_V5=y
>> CONFIG_SOC_AT91RM9200=y
>> CONFIG_SOC_AT91SAM9=y
>> CONFIG_AEABI=y
>> -CONFIG_UACCESS_WITH_MEMCPY=y
>> +# CONFIG_UACCESS_WITH_MEMCPY is not set
>> CONFIG_ZBOOT_ROM_TEXT=0x0
>> CONFIG_ZBOOT_ROM_BSS=0x0
>> CONFIG_ARM_APPENDED_DTB=y
> What is the reason to add the "# ... is not set" line? Given the default
> line of UACCESS_WITH_MEMCPY I suggest to just drop the line without
> replacement in the defconfigs.
>
Hi Uwe,
Without the explicit disabling, the user will be asked and could
possibly give the wrong answer as the help look as a cool feature and
the condition is very hard to understand.
Regards,
Jean-Christian
next prev parent reply other threads:[~2015-09-29 20:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 20:03 [PATCH 1/1] Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config jc at eclis.ch
2015-09-29 20:13 ` Nicolas Pitre
2015-09-29 20:35 ` Uwe Kleine-König
2015-09-29 20:59 ` Jean-Christian de Rivaz [this message]
2015-09-29 22:01 ` Alexandre Belloni
2015-09-29 22:18 ` Russell King - ARM Linux
2015-09-29 22:53 ` Alexandre Belloni
2015-09-29 23:19 ` Nicolas Pitre
-- strict thread matches above, loose matches on Subject: below --
2015-09-29 22:32 jc at eclis.ch
2015-09-30 6:10 ` Uwe Kleine-König
2015-09-30 10:13 ` Jean-Christian de Rivaz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560AFBC2.5050000@eclis.ch \
--to=jc@eclis$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox