From: xerofoify@gmail•com (nick)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RESENDv2] mach:-s3c64xx:Output trace information with WARN_ON if calls for setting up gpio board configuration fail in s3c64xx_i2s_cfg_gpio
Date: Wed, 30 Sep 2015 22:26:31 -0400 [thread overview]
Message-ID: <560C99D7.2090006@gmail.com> (raw)
In-Reply-To: <560C74C7.7030409@samsung.com>
On 2015-09-30 07:48 PM, Krzysztof Kozlowski wrote:
> On 30.09.2015 11:07, Nicholas Krause wrote:
>> This fixes the function s3c64xx_i2c_cfg_gpio to log output to the
>> kernel log buff with WARN_ON if any of the calls to either
>> s3c_gpio_cfgpin_range or s3c_gpio_cfgpin fail as we cannot exit
>> from s3c64xx_i2s_cfg_gpio if any of these calls fail due to
>> other intended function work being required to complete.
>
> This is better now.
>
>> Therefore
>> due to this output our failed calls by means of WARN_ON to the
>> kernel log buffer for failed configuration of gpio devices using
>> this driver file.
>
> I don't get this sentence. What do you want to say?
>
Fixed this in the v3 version.
>
>> v2:Fix Patch Wording as it was clearly confusing and incorrect
>
> Changelog goes after --- separator.
>
> Last question - have you compiled it? I mean truly compiled like
> generated object file and linked objects into vmlinux?
I rebuild and it seems indeed there was a build warning. Sometimes through
rarely ccache can cause issues with this and therefore did a clean build to
make sure that the build was indeed working correctly without failure.
Sorry,
Nick
>
> Best regards,
> Krzysztof
>
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail•com>
>> ---
>> arch/arm/mach-s3c64xx/dev-audio.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/mach-s3c64xx/dev-audio.c b/arch/arm/mach-s3c64xx/dev-audio.c
>> index ff780a8..5e7538b 100644
>> --- a/arch/arm/mach-s3c64xx/dev-audio.c
>> +++ b/arch/arm/mach-s3c64xx/dev-audio.c
>> @@ -36,10 +36,10 @@ static int s3c64xx_i2s_cfg_gpio(struct platform_device *pdev)
>> base = S3C64XX_GPE(0);
>> break;
>> case 2:
>> - s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5));
>> - s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5));
>> - s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5));
>> - s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(5));
>> + WARN_ON(s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5)));
>> + WARN_ON(s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5)));
>> + WARN_ON(s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5)));
>> + WARN_ON(s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(5));)
>> return 0;
>> default:
>> printk(KERN_DEBUG "Invalid I2S Controller number: %d\n",
>> @@ -47,7 +47,7 @@ static int s3c64xx_i2s_cfg_gpio(struct platform_device *pdev)
>> return -EINVAL;
>> }
>>
>> - s3c_gpio_cfgpin_range(base, 5, S3C_GPIO_SFN(3));
>> + WARN_ON(s3c_gpio_cfgpin_range(base, 5, S3C_GPIO_SFN(3)));
>>
>> return 0;
>> }
>>
>
prev parent reply other threads:[~2015-10-01 2:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 2:07 [PATCH RESENDv2] mach:-s3c64xx:Output trace information with WARN_ON if calls for setting up gpio board configuration fail in s3c64xx_i2s_cfg_gpio Nicholas Krause
2015-09-30 23:48 ` Krzysztof Kozlowski
2015-10-01 2:26 ` nick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560C99D7.2090006@gmail.com \
--to=xerofoify@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox