From: javier@osg•samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] ARM: multi_v7_defconfig: Enable Maxim 8997 family drivers
Date: Wed, 14 Oct 2015 10:27:49 +0200 [thread overview]
Message-ID: <561E1205.1040203@osg.samsung.com> (raw)
In-Reply-To: <561D04BB.1080406@samsung.com>
Hello Krzysztof,
On 10/13/2015 03:18 PM, Krzysztof Kozlowski wrote:
> W dniu 13.10.2015 o 17:36, Javier Martinez Canillas pisze:
>> Hello Krzysztof,
>>
>> On Tue, Oct 13, 2015 at 3:27 AM, Krzysztof Kozlowski
>> <k.kozlowski@samsung•com> wrote:
>>> Enable support for Maxim 8997 Multi Function Device present on Trats and
>>> Origen boards by toggling on drivers: main MFD, charger, haptic motor,
>>> regulator, LED and RTC.
>>>
>>> This allows to test and usage of these boards with multi_v7 config.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
>>> ---
>>
>> [snip]
>>
>>> CONFIG_MFD_MAX77686=y
>>> CONFIG_MFD_MAX77693=y
>>> CONFIG_MFD_MAX8907=y
>>> +CONFIG_MFD_MAX8997=y
>>
>> Only slightly related with your patch but some of the MFD driver for
>> PMICs used in Exynos boards (like MAX77686) have a tristate Kconfig
>> symbol while others like this one have a boolean. Do you know if there
>> are any restrictions w.r.t build this as module or is just an
>> arbitrary decision? I'm asking since probably we should either allow
>> this to build as a module or convert the others to boolean.
>
> First, thanks for reviewing the patches.
>
You are welcome.
> As for the question, I wasn't involved in development of these older
> drivers for older boards. I don't know their internals. AFAIK there were
> no specific restrictions, except the usual:
>
> 1. Not all other drivers using resources provided by these, took the
> reference to given resource (e.g. get regulator).
>
> 2. Not all consumer drivers supported deferred probe for given resource
> (e.g. regulator, clock), see: "regulators: max77693: register driver
> earlier to avoid deferred probe". In general USB gadget subsystem has
> this issue. Actually the mentioned max77693 regulator driver should be
> changed from tristate to built-in because of this.
>
> I don't remember any other important issues so if you fix 1 and 2 then
> this can be probably safely switched to modules. Of course after testing.
>
Thanks for the explanation. I neither plan to fix these issues nor changing
these symbols to tristate since I don't have access to the hardware to test.
I asked mostly because I was curious and to know if I should change the MFD
drivers to boolean for the PMIC present in boards I have access, to make it
consistent. But as you said is the other way around, that it would be good
to allow these drivers to be built as a module.
> Best regards,
> Krzysztof
>
> --
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-10-14 8:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 1:27 [PATCH 1/4] ARM: exynos_defconfig: Enable Maxim 8997 family drivers Krzysztof Kozlowski
2015-10-13 1:27 ` [PATCH 2/4] ARM: exynos_defconfig: Enable Maxim 77693 LED and haptic drivers Krzysztof Kozlowski
2015-10-13 8:25 ` Javier Martinez Canillas
2015-10-13 1:27 ` [PATCH 3/4] ARM: multi_v7_defconfig: Enable Maxim 8997 family drivers Krzysztof Kozlowski
2015-10-13 8:36 ` Javier Martinez Canillas
2015-10-13 13:18 ` Krzysztof Kozlowski
2015-10-14 8:27 ` Javier Martinez Canillas [this message]
2015-10-13 1:27 ` [PATCH 4/4] ARM: multi_v7_defconfig: Enable Maxim 77693 LED and haptic drivers Krzysztof Kozlowski
2015-10-13 8:38 ` Javier Martinez Canillas
2015-10-13 8:24 ` [PATCH 1/4] ARM: exynos_defconfig: Enable Maxim 8997 family drivers Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561E1205.1040203@osg.samsung.com \
--to=javier@osg$(echo .)samsung.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox