From: julien.grall@citrix•com (Julien Grall)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] xen/arm: Enable cpu_hotplug.c
Date: Wed, 14 Oct 2015 23:51:41 +0100 [thread overview]
Message-ID: <561EDC7D.1050005@citrix.com> (raw)
In-Reply-To: <1444844997-27314-1-git-send-email-stefano.stabellini@eu.citrix.com>
Hi Stefano,
On 14/10/2015 18:49, Stefano Stabellini wrote:
> Build cpu_hotplug for ARM and ARM64 guests.
>
> Rename arch_(un)register_cpu to xen_(un)register_cpu and provide an
> empty implementation on ARM and ARM64. On x86 just call
> arch_(un)register_cpu as we are already doing.
>
> Initialize cpu_hotplug on ARM.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu•citrix.com>
> ---
> arch/arm/include/asm/xen/hypervisor.h | 8 ++++++++
> arch/x86/include/asm/xen/hypervisor.h | 5 +++++
> arch/x86/xen/enlighten.c | 15 +++++++++++++++
> drivers/xen/Makefile | 2 --
> drivers/xen/cpu_hotplug.c | 6 ++++--
> 5 files changed, 32 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/include/asm/xen/hypervisor.h b/arch/arm/include/asm/xen/hypervisor.h
> index 04ff8e7..2bc418a 100644
> --- a/arch/arm/include/asm/xen/hypervisor.h
> +++ b/arch/arm/include/asm/xen/hypervisor.h
> @@ -26,4 +26,12 @@ void __init xen_early_init(void);
> static inline void xen_early_init(void) { return; }
> #endif
>
I know that those helpers are empty for now. But I would prefer to see
them protected by (FWIW, it's what you did for x86).
#ifdef CONFIG_CPU_HOTPLUG
> +static inline void xen_arch_register_cpu(int num)
> +{
> +}
> +
> +static inline void xen_arch_unregister_cpu(int num)
> +{
> +}
> +
#endif
> #endif /* _ASM_ARM_XEN_HYPERVISOR_H */
[...]
> diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
> index cc6513a..122b351 100644
> --- a/drivers/xen/cpu_hotplug.c
> +++ b/drivers/xen/cpu_hotplug.c
> @@ -11,7 +11,7 @@
> static void enable_hotplug_cpu(int cpu)
> {
> if (!cpu_present(cpu))
> - arch_register_cpu(cpu);
> + xen_arch_register_cpu(cpu);
>
> set_cpu_present(cpu, true);
> }
> @@ -19,7 +19,7 @@ static void enable_hotplug_cpu(int cpu)
> static void disable_hotplug_cpu(int cpu)
> {
> if (cpu_present(cpu))
> - arch_unregister_cpu(cpu);
> + xen_arch_unregister_cpu(cpu);
>
> set_cpu_present(cpu, false);
> }
> @@ -102,8 +102,10 @@ static int __init setup_vcpu_hotplug_event(void)
> static struct notifier_block xsn_cpu = {
> .notifier_call = setup_cpu_watcher };
>
> +#ifdef CONFIG_X86
> if (!xen_pv_domain())
> return -ENODEV;
> +#endif
For ARM, you need to check if it's a Xen domain. Otherwise a kernel
aware of Xen won't boot on baremetal.
>
> register_xenstore_notifier(&xsn_cpu);
>
>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-10-14 22:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 17:49 xen,arm: enable cpu_hotplug Stefano Stabellini
2015-10-14 17:49 ` [PATCH 1/3] xen/arm: Enable cpu_hotplug.c Stefano Stabellini
2015-10-14 18:05 ` [Xen-devel] " Konrad Rzeszutek Wilk
2015-10-14 18:17 ` Stefano Stabellini
2015-10-16 15:21 ` Stefano Stabellini
2015-10-14 22:51 ` Julien Grall [this message]
2015-10-16 15:23 ` Stefano Stabellini
2015-10-14 17:49 ` [PATCH 2/3] xen, cpu_hotplug: call device_offline instead of cpu_down Stefano Stabellini
2015-10-14 17:49 ` [PATCH 3/3] xen/arm: don't try to re-register vcpu_info on cpu_hotplug Stefano Stabellini
2015-10-14 22:32 ` Julien Grall
2015-10-16 15:31 ` Stefano Stabellini
2015-10-14 23:23 ` xen,arm: enable cpu_hotplug Julien Grall
2015-10-15 8:39 ` [Xen-devel] " Ian Campbell
2015-10-15 9:57 ` Julien Grall
2015-10-15 9:58 ` Julien Grall
2015-10-16 15:44 ` Stefano Stabellini
2015-10-16 15:41 ` Stefano Stabellini
2015-10-16 15:45 ` Julien Grall
2015-10-16 15:45 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561EDC7D.1050005@citrix.com \
--to=julien.grall@citrix$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox