From: a0131933@ti•com (Lokesh Vutla)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: OMAP2+: Fix oops with LPAE and more than 2GB of memory
Date: Mon, 19 Oct 2015 19:26:34 +0530 [thread overview]
Message-ID: <5624F692.5070302@ti.com> (raw)
In-Reply-To: <20151016192300.GD24370@atomide.com>
On Saturday 17 October 2015 12:53 AM, Tony Lindgren wrote:
> * Lokesh Vutla <a0131933@ti•com> [151015 08:21]:
[..snip..]
>>>
>
> 8< ----------------------From c37732f6cea23d15faaaaa357cf698833c03ce05 Mon Sep 17 00:00:00 2001
> Date: Fri, 16 Oct 2015 12:16:21 -0700
> Subject: [PATCH] ARM: OMAP2+: Fix oops with LPAE and more than 2GB of memory
>
> On boards with more than 2GB of RAM booting goes wrong with things not
> working and we're getting lots of l3 warnings:
>
> WARNING: CPU: 0 PID: 1 at drivers/bus/omap_l3_noc.c:147
> l3_interrupt_handler+0x260/0x384()
> 44000000.ocp:L3 Custom Error: MASTER MMC6 TARGET DMM1 (Idle):
> Data Access in User mode during Functional access
> ...
> [<c044e158>] (scsi_add_host_with_dma) from [<c04705c8>]
> (ata_scsi_add_hosts+0x5c/0x18c)
> [<c04705c8>] (ata_scsi_add_hosts) from [<c046b13c>]
> (ata_host_register+0x150/0x2cc)
> [<c046b13c>] (ata_host_register) from [<c046b38c>]
> (ata_host_activate+0xd4/0x124)
> [<c046b38c>] (ata_host_activate) from [<c047f42c>]
> (ahci_host_activate+0x5c/0x194)
> [<c047f42c>] (ahci_host_activate) from [<c0480854>]
> (ahci_platform_init_host+0x1f0/0x3f0)
> [<c0480854>] (ahci_platform_init_host) from [<c047c9dc>]
> (ahci_probe+0x70/0x98)
> [<c047c9dc>] (ahci_probe) from [<c04220cc>]
> (platform_drv_probe+0x54/0xb4)
>
> Let's fix the issue by enabling ZONE_DMA for LPAE. Note that we need to
> limit dma_zone_size to 2GB as the rest of the RAM is beyond the 4GB limit.
>
> Let's also fix things for dra7 as done in similar patches in the TI tree
> by Lokesh Vutla <lokeshvutla@ti•com>.
Looks good to me.
Reviewed-by: Lokesh Vutla <lokeshvutla@ti•com>
Since there is a big hole with in the memory space, we might also need
to enable SPARSEMEM ?
Thanks and regards,
Lokesh
>
> Signed-off-by: Tony Lindgren <tony@atomide•com>
>
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -49,6 +49,7 @@ config SOC_OMAP5
> select OMAP_INTERCONNECT
> select OMAP_INTERCONNECT_BARRIER
> select PM_OPP if PM
> + select ZONE_DMA if ARM_LPAE
>
> config SOC_AM33XX
> bool "TI AM33XX"
> @@ -78,6 +79,7 @@ config SOC_DRA7XX
> select OMAP_INTERCONNECT
> select OMAP_INTERCONNECT_BARRIER
> select PM_OPP if PM
> + select ZONE_DMA if ARM_LPAE
>
> config ARCH_OMAP2PLUS
> bool
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -243,6 +243,9 @@ static const char *const omap5_boards_compat[] __initconst = {
> };
>
> DT_MACHINE_START(OMAP5_DT, "Generic OMAP5 (Flattened Device Tree)")
> +#if defined(CONFIG_ZONE_DMA) && defined(CONFIG_ARM_LPAE)
> + .dma_zone_size = SZ_2G,
> +#endif
> .reserve = omap_reserve,
> .smp = smp_ops(omap4_smp_ops),
> .map_io = omap5_map_io,
> @@ -288,6 +291,9 @@ static const char *const dra74x_boards_compat[] __initconst = {
> };
>
> DT_MACHINE_START(DRA74X_DT, "Generic DRA74X (Flattened Device Tree)")
> +#if defined(CONFIG_ZONE_DMA) && defined(CONFIG_ARM_LPAE)
> + .dma_zone_size = SZ_2G,
> +#endif
> .reserve = omap_reserve,
> .smp = smp_ops(omap4_smp_ops),
> .map_io = dra7xx_map_io,
> @@ -308,6 +314,9 @@ static const char *const dra72x_boards_compat[] __initconst = {
> };
>
> DT_MACHINE_START(DRA72X_DT, "Generic DRA72X (Flattened Device Tree)")
> +#if defined(CONFIG_ZONE_DMA) && defined(CONFIG_ARM_LPAE)
> + .dma_zone_size = SZ_2G,
> +#endif
> .reserve = omap_reserve,
> .map_io = dra7xx_map_io,
> .init_early = dra7xx_init_early,
>
next prev parent reply other threads:[~2015-10-19 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 23:13 [PATCH] ARM: OMAP2+: Fix oops with LPAE and more than 2GB of memory Tony Lindgren
2015-10-14 3:46 ` Lokesh Vutla
2015-10-14 16:02 ` Tony Lindgren
2015-10-15 7:55 ` Lokesh Vutla
2015-10-15 14:05 ` Tony Lindgren
2015-10-15 15:14 ` Lokesh Vutla
2015-10-16 19:23 ` Tony Lindgren
2015-10-19 13:56 ` Lokesh Vutla [this message]
2015-10-19 15:46 ` Tony Lindgren
2015-10-14 9:15 ` Arnd Bergmann
2015-10-14 16:17 ` Tony Lindgren
2015-10-14 20:12 ` Arnd Bergmann
2015-10-14 20:28 ` Suman Anna
2015-10-14 20:44 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5624F692.5070302@ti.com \
--to=a0131933@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox