From: huawei.libin@huawei•com (libin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm64: ftrace: function_graph: dump real return addr in call trace
Date: Thu, 22 Oct 2015 08:55:43 +0800 [thread overview]
Message-ID: <5628340F.5080902@huawei.com> (raw)
In-Reply-To: <20151020153227.GL11226@e104818-lin.cambridge.arm.com>
? 2015/10/20 23:32, Catalin Marinas ??:
> On Thu, Oct 15, 2015 at 10:18:12AM -0400, Steven Rostedt wrote:
>> On Thu, 15 Oct 2015 13:51:33 +0100
>> Will Deacon <will.deacon@arm•com> wrote:
>>
>>> Is this the same old problem caused by e306dfd06fcb ("ARM64: unwind: Fix
>>> PC calculation")? I've said previously that I'm happy to revert that if
>>> we're the only architecture with this behaviour, but Akashi resisted
>>> because there are other issues with ftrace that he was hoping to address
>>> and they would resolve this too.
>>
>> Just a reference, but this patch is pretty much exactly what x86
>> currently has. I wonder if I should make that function generic for all
>> archs to use.
>>
>> If you accept this patch, I can look at what archs do and pull out the
>> common code and place it into the core code and have the archs call
>> that instead.
>
> The difference I see from the sh and x86 version is that we have this -4
> on arm64, introduced by e306dfd06fcb as Will mentioned above (it seemed
> to have caused more problems that it solved). I think we should revert
> that commit first just to be in line with other architectures and then
> apply additional fixes as needed.
>
> Question for Li Bin: is your patch still needed if we revert commit
> e306dfd06fcb?
>
It still be needed, but it can be implemented in generic for all archs
as Steve suggested.
Thanks,
Li Bin
> Thanks.
>
next prev parent reply other threads:[~2015-10-22 0:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 12:12 [PATCH] arm64: ftrace: function_graph: dump real return addr in call trace Li Bin
2015-10-15 12:46 ` Arnd Bergmann
2015-10-15 12:51 ` Will Deacon
2015-10-15 14:18 ` Steven Rostedt
2015-10-20 15:32 ` Catalin Marinas
2015-10-22 0:55 ` libin [this message]
2015-10-22 1:13 ` Steven Rostedt
2015-10-28 15:21 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5628340F.5080902@huawei.com \
--to=huawei.libin@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox