From: robin.murphy@arm•com (Robin Murphy)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 4/6] memory: mediatek: Add SMI driver
Date: Tue, 27 Oct 2015 13:24:34 +0000 [thread overview]
Message-ID: <562F7B12.7030201@arm.com> (raw)
In-Reply-To: <1444357388-30257-5-git-send-email-yong.wu@mediatek.com>
On 09/10/15 03:23, Yong Wu wrote:
[...]
> +static int mtk_smi_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct mtk_smi_data *smidata;
> + int ret;
> +
> + if (!dev->pm_domain)
> + return -EPROBE_DEFER;
> +
> + smidata = devm_kzalloc(dev, sizeof(*smidata), GFP_KERNEL);
> + if (!smidata)
> + return -ENOMEM;
> +
> + smidata->clk_apb = devm_clk_get(dev, "apb");
> + if (IS_ERR(smidata->clk_apb))
> + return PTR_ERR(smidata->clk_apb);
> +
> + smidata->clk_smi = devm_clk_get(dev, "smi");
> + if (IS_ERR(smidata->clk_smi))
> + return PTR_ERR(smidata->clk_smi);
> +
> + pm_runtime_enable(dev);
> + dev_set_drvdata(dev, smidata);
> + return ret;
ret is used uninitialised here, but you might as well just "return 0;"
and get rid of the variable entirely.
> +}
Robin.
next prev parent reply other threads:[~2015-10-27 13:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 2:23 [PATCH v5 0/6] MT8173 IOMMU SUPPORT Yong Wu
2015-10-09 2:23 ` [PATCH v5 1/6] dt-bindings: iommu: Add binding for mediatek IOMMU Yong Wu
2015-10-09 2:23 ` [PATCH v5 2/6] dt-bindings: mediatek: Add smi dts binding Yong Wu
2015-10-09 2:23 ` [PATCH v5 3/6] iommu: add ARM short descriptor page table allocator Yong Wu
2015-10-14 12:54 ` Joerg Roedel
2015-10-15 17:20 ` Will Deacon
2015-11-06 8:42 ` Yong Wu
2015-11-06 11:42 ` Will Deacon
2015-10-09 2:23 ` [PATCH v5 4/6] memory: mediatek: Add SMI driver Yong Wu
2015-10-27 13:24 ` Robin Murphy [this message]
2015-10-31 8:32 ` Yong Wu
2015-10-09 2:23 ` [PATCH v5 5/6] iommu/mediatek: Add mt8173 IOMMU driver Yong Wu
2015-10-14 12:53 ` Joerg Roedel
2015-10-26 5:23 ` Yong Wu
2015-10-27 13:25 ` Robin Murphy
2015-10-31 8:28 ` Yong Wu
2015-10-09 2:23 ` [PATCH v5 6/6] dts: mt8173: Add iommu/smi nodes for mt8173 Yong Wu
2015-10-14 12:56 ` [PATCH v5 0/6] MT8173 IOMMU SUPPORT Joerg Roedel
2015-10-22 4:40 ` Yong Wu
2015-10-23 9:26 ` Joerg Roedel
2015-11-24 5:58 ` Yong Wu
2015-11-24 10:38 ` Thierry Reding
2015-11-25 1:30 ` Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F7B12.7030201@arm.com \
--to=robin.murphy@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox