From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/4] ARM: dts: Add SROMc to Exynos 5410
Date: Wed, 28 Oct 2015 18:36:04 +0900 [thread overview]
Message-ID: <56309704.90904@samsung.com> (raw)
In-Reply-To: <563095BE.9050106@samsung.com>
On 28.10.2015 18:30, Pankaj Dubey wrote:
> Hi
>
> On Wednesday 28 October 2015 12:54 PM, Krzysztof Kozlowski wrote:
>> On 28.10.2015 16:06, Pavel Fedin wrote:
>>> Hello!
>>>
>>>>> + sromc: sromc at 12250000 {
>>>>> + compatible = "samsung,exynos-srom";
>>>>> + reg = <0x12250000 0x10>;
>>>>
>>>> Isn't 0x10 too small (SROM_BC3 won't be mapped)?
>>>
>>> Muhaha, indeed, thanks for noticing this.
>>> By the way, i've just checked exynos4.dtsi and exynos5.dtsi, they
>>> specify the same size. Did reviewers overlook this small thing?
>>
>> Yep, I pointed that 0x100 (from first version of patchset) is too big...
>> but did not exactly check the length of new value.
>>
>
> Yes, once you pointed out I checked UM for Exynos4415, Exynos5250,
> Exynos5420 and Exynos5410 and all these manuals talks about SROM_BC{0-3}
> only. There is no offset such as SROM_BC{4,5} at least in these SoC
> manuals. Accordingly I modified size from 0x100 to 0x10. But looks like
> I missed to remove SROM_BC{{4,5} from exynos-srom.h. I checked only
> these registers are used in the driver, so as such it should not cause
> any issue in driver as of now, only we have some redundant entry in
> exynos-srom.h which can be removed if it's not applicable for any of
> Exynos SoC, after confirmation from Kukjin.
I was not referring to SROM_BC[45] but to SROM_BC3 which has the offset
of 0x10.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-10-28 9:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 8:43 [PATCH v2 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-10-27 8:43 ` [PATCH v2 1/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-10-28 2:12 ` Krzysztof Kozlowski
2015-10-28 7:06 ` Pavel Fedin
2015-10-28 7:24 ` Krzysztof Kozlowski
2015-10-28 7:25 ` Pavel Fedin
2015-10-28 9:30 ` Pankaj Dubey
2015-10-28 9:36 ` Krzysztof Kozlowski [this message]
2015-10-28 9:39 ` Pavel Fedin
2015-10-27 8:43 ` [PATCH v2 2/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-10-27 8:43 ` [PATCH v2 3/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
2015-10-27 8:43 ` [PATCH v2 4/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-10-28 1:52 ` [PATCH v2 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56309704.90904@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox