From: lars@metafoo•de (Lars-Peter Clausen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 4/4] iio: humidity: si7020: added No Hold read mode
Date: Thu, 29 Oct 2015 10:17:53 +0100 [thread overview]
Message-ID: <5631E441.6030600@metafoo.de> (raw)
In-Reply-To: <ba63445a2f9af32bcbad698039041cbf@rainloop.corna.info>
>> So maybe more like this:
>>
>> static inline bool i2c_check_quirks(struct i2c_adapter *adap, u64 quirks)
>> {
>> if (!adap->quirks)
>> return false;
>> return (adap->quirks->flags & quirks) == quirks;
>> }
>
> Should I use bool (like in your snippet) or int (like i2c_check_functionality) as return type?
I'd use bool, given that the result is a boolean value. It's semantically
more clear this way.
next prev parent reply other threads:[~2015-10-29 9:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 20:11 [PATCH 1/4] i2c: added i2c quirk flag for unsupported clock stretching Nicola Corna
2015-10-27 20:11 ` [PATCH 2/4] i2c: added I2C_AQ_NO_CLK_STRETCH to i2c-algo-bit.c Nicola Corna
2015-10-27 20:11 ` [PATCH 3/4] i2c: added I2C_AQ_NO_CLK_STRETCH to i2c-bcm2835.c Nicola Corna
2015-10-28 19:16 ` Eric Anholt
2015-10-29 4:10 ` Stephen Warren
2015-10-27 20:11 ` [PATCH v3 4/4] iio: humidity: si7020: added No Hold read mode Nicola Corna
2015-10-27 23:30 ` Wolfram Sang
2015-10-28 6:46 ` Nicola Corna
2015-10-28 6:58 ` [PATCH v4 " Nicola Corna
2015-10-28 9:38 ` Lars-Peter Clausen
2015-10-28 18:35 ` Nicola Corna
2015-10-28 18:46 ` Lars-Peter Clausen
2015-10-28 20:17 ` Nicola Corna
2015-10-28 20:19 ` Nicola Corna
2015-10-29 9:17 ` Lars-Peter Clausen [this message]
2015-10-29 11:34 ` [PATCH v2 1/5] i2c: add i2c quirk flag for unsupported clock stretching Nicola Corna
2015-10-29 11:34 ` [PATCH v2 2/5] i2c: add I2C_AQ_NO_CLK_STRETCH to i2c-algo-bit.c Nicola Corna
2015-11-30 17:26 ` Wolfram Sang
2015-10-29 11:34 ` [PATCH v2 3/5] i2c: add I2C_AQ_NO_CLK_STRETCH to i2c-bcm2835.c Nicola Corna
2015-11-30 17:27 ` Wolfram Sang
2015-10-29 11:34 ` [PATCH 4/5] i2c: add i2c_check_quirks helper function Nicola Corna
2015-10-31 10:18 ` Jonathan Cameron
2015-11-30 17:28 ` Wolfram Sang
2015-11-30 17:30 ` Wolfram Sang
2015-10-29 11:34 ` [PATCH v5 5/5] iio: humidity: si7020: add No Hold read mode Nicola Corna
2015-10-31 10:21 ` Jonathan Cameron
2015-11-30 17:33 ` Wolfram Sang
2015-12-05 18:24 ` Jonathan Cameron
2015-12-05 19:01 ` Wolfram Sang
2015-11-30 17:24 ` [PATCH v2 1/5] i2c: add i2c quirk flag for unsupported clock stretching Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5631E441.6030600@metafoo.de \
--to=lars@metafoo$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox