Subject: [Xen-devel] [PATCH 06/13] Xen: ARM: Add support for mapping amba device mmio

From: [email-masked] (David Vrabel)
Date: Tue, 17 Nov 2015 16:36:24 +0000

On 17/11/15 09:57, shannon.zhao at linaro.org wrote:
> From: Shannon Zhao <[email-masked]>
> 
> Add a bus_notifier for AMBA bus device in order to map the device
> mmio regions when DOM0 booting with ACPI.
[...]
> +static int xen_map_amba_device_mmio(struct amba_device *adev)
> +{
> +	int rc = 0;
> +	struct resource *r = &adev->res;
> +
> +	if (resource_type(r) == IORESOURCE_MEM)
> +	{

Haven't I seen something like this before...?

This is (almost) identical to the code added for platform devices.  This
needs to be generic.

David