From: nm@ti•com (Nishanth Menon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 01/18] ARM: am57xx: cl-som-am57x: dts: add basic module support
Date: Wed, 25 Nov 2015 15:36:18 -0600 [thread overview]
Message-ID: <565629D2.2010401@ti.com> (raw)
In-Reply-To: <1448433590-1399-2-git-send-email-lifshitz@compulab.co.il>
On 11/25/2015 12:39 AM, Dmitry Lifshitz wrote:
[...]
> diff --git a/arch/arm/boot/dts/am57xx-cl-som-am57x.dts b/arch/arm/boot/dts/am57xx-cl-som-am57x.dts
> new file mode 100644
> index 0000000..b11d7da
> --- /dev/null
> +++ b/arch/arm/boot/dts/am57xx-cl-som-am57x.dts
[...]
> +/ {
> + model = "CompuLab CL-SOM-AM57x";
> + compatible = "compulab,cl-som-am57x", "ti,am5728", "ti,dra742", "ti,dra74", "ti,dra7";
> +
> + memory {
> + device_type = "memory";
> + reg = <0x80000000 0x20000000>; /* 512 MB - minimal configuration */
I think if you like to enable LPAE, the format might look a little
different..
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&leds_pins_default>;
> +
> + led at 0 {
> + label = "cl-som-am57x:green";
> + gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";
> + };
> + };
> +};
> +
> +&dra7_pmx_core {
> + leds_pins_default: leds_pins_default {
> + pinctrl-single,pins = <
> + DRA7XX_CORE_IOPAD(0x347c, PIN_OUTPUT | MUX_MODE14) /* gpmc_a15.gpio2_5 */
> + >;
> + };
> +
> + i2c1_pins_default: i2c1_pins_default {
> + pinctrl-single,pins = <
> + DRA7XX_CORE_IOPAD(0x3800, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c1_sda.sda */
> + DRA7XX_CORE_IOPAD(0x3804, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c1_scl.scl */
> + >;
> + };
> +
> + tps659038_pins_default: tps659038_pins_default {
> + pinctrl-single,pins = <
> + DRA7XX_CORE_IOPAD(0x3818, PIN_INPUT_PULLUP | MUX_MODE14) /* wakeup0.gpio1_0 */
> + >;
> + };
Generic comment: As per requirements of the SoC -> all pinctrl must be
done in bootloader. this was a recommendation that came in too late
for TI platforms that got introduced in upstream, but that cleanup
should eventually take place as well.
> +};
> +
> +&i2c1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c1_pins_default>;
> + clock-frequency = <400000>;
> +
> + tps659038: tps659038 at 58 {
> + compatible = "ti,tps659038";
> + reg = <0x58>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
Also See: https://patchwork.kernel.org/patch/7596541/ ->
Documentation/devicetree/bindings/i2c/i2c.txt -> since you seem to
have a PMIC with power button, you might be able to get wakeup source
also there.
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&tps659038_pins_default>;
> +
> + #interrupt-cells = <2>;
> + interrupt-controller;
> +
> + ti,system-power-controller;
Assuming powerhold signal and BOOT0,1 is proper here, else poweroff
will never work.
> +
> + tps659038_pmic {
> + compatible = "ti,tps659038-pmic";
> +
> + regulators {
> + smps12_reg: smps12 {
> + /* VDD_MPU */
> + regulator-name = "smps12";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1250000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps3_reg: smps3 {
> + /* VDD_DDR */
> + regulator-name = "smps3";
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps45_reg: smps45 {
> + /* VDD_DSPEVE */
> + regulator-name = "smps45";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1160000>;
1.25v if you want to support OPP_HIGH. as per latest data sheet.
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps6_reg: smps6 {
> + /* VDD_GPU */
> + regulator-name = "smps6";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1160000>;
1.25v if you want to support OPP_HIGH. as per latest data sheet.
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps7_reg: smps7 {
> + /* VDD_CORE */
> + regulator-name = "smps7";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1160000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps8_reg: smps8 {
> + /* VDD_IVA */
> + regulator-name = "smps8";
> + regulator-min-microvolt = < 850000>;
> + regulator-max-microvolt = <1160000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps9_reg: smps9 {
> + /* PMIC_3V3 */
> + regulator-name = "smps9";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> +
> + ldo1_reg: ldo1 {
> + /* VDD_SD / VDDSHV8 */
> + regulator-name = "ldo1";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
for eventual UHS mode support, it is recommended to keep VDD_SD
separate from VDDSHV8. many of TI evms also suffer from this issue :(
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo2_reg: ldo2 {
> + /* VDD_1V8 */
> + regulator-name = "ldo2";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo3_reg: ldo3 {
> + /* VDDA_1V8_PHYA */
> + regulator-name = "ldo3";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo4_reg: ldo4 {
> + /* VDDA_1V8_PHYB */
> + regulator-name = "ldo4";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
Happy to see this is already split up. you might want to document
which PHYs are supplied by PHYA/B in comments for future reference
instead of having to dig through schematics to figure that out..
> +
> + ldo9_reg: ldo9 {
> + /* VDD_RTC */
> + regulator-name = "ldo9";
> + regulator-min-microvolt = <1050000>;
> + regulator-max-microvolt = <1050000>;
> + regulator-always-on;
> + regulator-boot-on;
as per data sheet:
"VD_RTC can optionally be tied to VD_CORE and operate at the VD_CORE
AVS voltages."
I assume that is not the case here.
> + };
> +
> + ldoln_reg: ldoln {
> + /* VDDA_1V8_PLL */
> + regulator-name = "ldoln";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldousb_reg: ldousb {
> + /* VDDA_3V_USB: VDDA_USBHS33 */
> + regulator-name = "ldousb";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
All SoC VDDAs must be always-on.
[...]
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2015-11-25 21:36 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 6:39 [PATCH 00/18] Add support for CL-SOM-AM57X and SBC-AM57X Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 01/18] ARM: am57xx: cl-som-am57x: dts: add basic module support Dmitry Lifshitz
2015-11-25 20:05 ` Rob Herring
2015-11-25 21:36 ` Nishanth Menon [this message]
2015-11-29 12:10 ` Dmitry Lifshitz
2015-11-29 17:06 ` Nishanth Menon
2015-11-30 13:29 ` Dmitry Lifshitz
2015-11-30 13:36 ` Nishanth Menon
2015-11-30 13:36 ` Nishanth Menon
2015-11-30 15:55 ` Rob Herring
2015-11-30 14:25 ` [PATCH v2 " Dmitry Lifshitz
2015-11-30 21:54 ` Tony Lindgren
2015-12-01 16:24 ` Dmitry Lifshitz
2015-12-01 16:43 ` Tony Lindgren
2015-12-01 16:47 ` Nishanth Menon
2015-12-01 17:03 ` Tony Lindgren
2015-11-25 6:39 ` [PATCH 02/18] ARM: am57xx: cl-som-am57x: dts: add RTC support Dmitry Lifshitz
2015-11-30 21:50 ` Tony Lindgren
2015-11-25 6:39 ` [PATCH 03/18] ARM: am57xx: cl-som-am57x: dts: add I2C3 support Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 04/18] ARM: am57xx: cl-som-am57x: dts: add EEPROM support Dmitry Lifshitz
2015-11-30 14:23 ` Igor Grinberg
2015-11-30 14:33 ` [PATCH v2 " Dmitry Lifshitz
2015-11-30 14:44 ` Igor Grinberg
2015-11-25 6:39 ` [PATCH 05/18] ARM: am57xx: cl-som-am57x: dts: add eMMC support Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 06/18] ARM: am57xx: cl-som-am57x: dts: add spi-flash support Dmitry Lifshitz
2015-11-30 14:26 ` [PATCH v2 " Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 07/18] ARM: am57xx: cl-som-am57x: dts: add dual EMAC support Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 08/18] ARM: am57xx: cl-som-am57x: dts: add USB support Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 09/18] ARM: am57xx: cl-som-am57x: dts: add touchscreen support Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 10/18] ARM: am57xx: cl-som-am57x: dts: add analog audio support Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 11/18] ARM: am57xx: sbc-am57x: dts: add basic board support Dmitry Lifshitz
2015-11-25 20:05 ` Rob Herring
2015-11-25 6:39 ` [PATCH 12/18] ARM: am57xx: cl-som-am57x: dts: add MMC1 support Dmitry Lifshitz
2015-11-30 14:28 ` [PATCH v2 " Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 13/18] ARM: am57xx: sbc-am57x: dts: add usb vbus pinmux Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 14/18] ARM: am57xx: sbc-am57x: dts: add EEPROM support Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 15/18] ARM: am57xx: sbc-am57x: dts: add GPIO extender support Dmitry Lifshitz
2015-11-25 21:41 ` Nishanth Menon
2015-11-30 14:28 ` [PATCH v2 15/18] ARM: am57xx: sbc-am57x: dts: add GPIO expander support Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 16/18] ARM: am57xx: sbc-am57x: dts: add LCD support Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 17/18] ARM: am57xx: compulab-sb-som: dts: add HDMI connector Dmitry Lifshitz
2015-11-25 6:39 ` [PATCH 18/18] ARM: am57xx: sbc-am57x: dts: add HDMI support Dmitry Lifshitz
2015-11-30 14:27 ` [PATCH v2 07/18] ARM: am57xx: cl-som-am57x: dts: add dual EMAC support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 00/19] Add support for CL-SOM-AM57X and SBC-AM57X Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V3 01/19] ARM: dts: am57xx: cl-som-am57x: add basic module support Dmitry Lifshitz
2015-12-02 15:23 ` Rob Herring
2015-12-03 16:20 ` Tony Lindgren
2015-12-01 18:03 ` [PATCH V2 02/19] ARM: dts: am57xx: cl-som-am57x: dts: add RTC support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 03/19] ARM: dts: am57xx: cl-som-am57x: add I2C3 support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V3 04/19] ARM: dts: am57xx: cl-som-am57x: add EEPROM support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 05/19] ARM: dts: am57xx: cl-som-am57x: add eMMC support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V3 06/19] ARM: dts: am57xx: cl-som-am57x: add spi-flash support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V3 07/19] ARM: dts: am57xx: cl-som-am57x: add dual EMAC support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 08/19] ARM: dts: am57xx: cl-som-am57x: add USB support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 09/19] ARM: dts: am57xx: cl-som-am57x: add touchscreen support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 10/19] ARM: dts: am57xx: cl-som-am57x: add analog audio support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 11/19] ARM: dts: am57xx: sbc-am57x: add basic board support Dmitry Lifshitz
2015-12-02 15:17 ` Rob Herring
2015-12-01 18:03 ` [PATCH V3 12/19] ARM: dts: am57xx: cl-som-am57x: add MMC1 support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 13/19] ARM: dts: am57xx: sbc-am57x: add usb vbus pinmux Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 14/19] ARM: dts: am57xx: sbc-am57x: add EEPROM support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V3 15/19] ARM: dts: am57xx: sbc-am57x: add GPIO expander support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 16/19] ARM: dts: am57xx: sbc-am57x: add LCD support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 17/19] ARM: dts: am57xx: compulab-sb-som: add HDMI connector Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH V2 18/19] ARM: dts: am57xx: sbc-am57x: add HDMI support Dmitry Lifshitz
2015-12-01 18:03 ` [PATCH 19/19] ARM: dts: am57xx: cl-som-am57x: skip resetting ETH PHYs Dmitry Lifshitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565629D2.2010401@ti.com \
--to=nm@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox