From: grygorii.strashko@ti•com (Grygorii Strashko)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH] clocksource: ti-32k: convert to platform device
Date: Fri, 27 Nov 2015 22:10:26 +0200 [thread overview]
Message-ID: <5658B8B2.5030505@ti.com> (raw)
In-Reply-To: <87h9kgcz1k.fsf@saruman.tx.rr.com>
Hi Felipe,
On 11/20/2015 08:21 PM, Felipe Balbi wrote:
> Grygorii Strashko <grygorii.strashko@ti•com> writes:
>> Since system clocksource is finally selected by Clocksource core at
>> fs_initcall stage during boot there are no reasons to initialize
>> ti_32k_timer at early boot stages. Hence, ti_32k_timer can be
>> converted to use platform device/driver model and its PM can be
>> implemented using PM runtime which is common for OMAP devices.
>>
>> Platform specific initialization code has to be disabled once as
>> ti_32k_timer is converted to platform device - otherwise OMAP platform
>> code will generate boot warnings.
>>
>> After this change, all counter_32k's platform code can be removed
>> once all OMAP boards will be converted to DT.
>>
>> Cc: Tony Lindgren <tony@atomide•com>
>> Cc: Felipe Balbi <balbi@ti•com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti•com>
>> ---
[...]
>> +
>> +static struct platform_driver ti_32k_driver __initdata = {
>> + .probe = ti_32k_probe,
>> + .driver = {
>> + .name = "ti_32k_timer",
>> + .of_match_table = of_match_ptr(ti_32k_of_table),
>> + }
>> +};
>> +
>> +static int __init ti_32k_init(void)
>> +{
>> + return platform_driver_register(&ti_32k_driver);
>> }
>> -CLOCKSOURCE_OF_DECLARE(ti_32k_timer, "ti,omap-counter32k",
>> - ti_32k_timer_init);
>> +
>> +subsys_initcall(ti_32k_init);
>> +
>> +MODULE_AUTHOR("Paul Mundt");
>> +MODULE_AUTHOR("Juha Yrj?l?");
>> +MODULE_DESCRIPTION("OMAP2 32k Timer");
>> +MODULE_ALIAS("platform:ti_32k_timer");
>> +MODULE_LICENSE("GPL v2");
>
> this will break clksource_of_init(), right ? Eventually, we want that to
> be the only thing called by our .init_time method. I'll leave it to Tony
> to decide, but IMO this is not a good path forward for timers.
>
Yeh :(. I did additional tests, and, unfortunately, this can't be used as is.
But not because of clocksource_of_init() which will just produce boot warning.
It can't be done because of sched_clock_register() which is expected to be
called during early boot time only and with disabled IRQs.
It was so tempting to try :)
Thanks for your comment.
--
regards,
-grygorii
next prev parent reply other threads:[~2015-11-27 20:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 17:22 [RFC PATCH] clocksource: ti-32k: convert to platform device Grygorii Strashko
2015-11-20 18:21 ` Felipe Balbi
2015-11-27 20:10 ` Grygorii Strashko [this message]
2015-11-30 16:28 ` Tony Lindgren
2015-12-01 15:08 ` Grygorii Strashko
2015-12-01 16:07 ` Tony Lindgren
2015-12-01 17:12 ` Grygorii Strashko
2015-12-01 17:24 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5658B8B2.5030505@ti.com \
--to=grygorii.strashko@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox