From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 5/5] ARM: exynos: select POWER_RESET_SYSCON and POWER_RESET_SYSCON_POWEROFF
Date: Wed, 02 Dec 2015 14:21:47 +0900 [thread overview]
Message-ID: <565E7FEB.3040806@samsung.com> (raw)
In-Reply-To: <010401d12c17$1e883d10$5b98b730$@samsung.com>
On 01.12.2015 18:03, Pavel Fedin wrote:
> Hello!
>
> Tested it on top of 4.4-rc3.
>
>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
>> index 3a10f1a8317a..d279edf9b10d 100644
>> --- a/arch/arm/mach-exynos/Kconfig
>> +++ b/arch/arm/mach-exynos/Kconfig
>> @@ -27,6 +27,9 @@ menuconfig ARCH_EXYNOS
>> select SRAM
>> select THERMAL
>> select MFD_SYSCON
>> + select POWER_RESET
>> + select POWER_RESET_SYSCON
>> + select POWER_RESET_SYSCON_POWEROFF
>
> "select POWER_SUPPLY" is missing here. Without is we get:
> --- cut ---
> warning: (ARCH_HISI && ARCH_INTEGRATOR && ARCH_EXYNOS && ARCH_VEXPRESS && REALVIEW_DT) selects POWER_RESET which has unmet direct
> dependencies (POWER_SUPPLY)
> warning: (ARCH_EXYNOS) selects POWER_RESET_SYSCON which has unmet direct dependencies (POWER_SUPPLY && POWER_RESET && OF)
> warning: (ARCH_EXYNOS) selects POWER_RESET_SYSCON_POWEROFF which has unmet direct dependencies (POWER_SUPPLY && POWER_RESET && OF)
> --- cut ---
>
>> help
>> Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5)
>
> Otherwise works fine.
>
> Tested-by: Pavel Fedin <p.fedin@samsung•com>
Testing was a little bit too late (late not only looking at date of v1
and v2 but even for v3)... I appreciate it but I applied it already and
in fact I sent a pull request with it.
Actually the proper fix I think is to remove the dependency between
POWER_RESET and POWER_SUPPLY.
Best regards,
Krzysztof
prev parent reply other threads:[~2015-12-02 5:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 5:17 [PATCH v3 0/5] Switch to generic syscon regmap based drivers Alim Akhtar
2015-11-20 5:17 ` [PATCH v3 1/5] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos3250 SoCs Alim Akhtar
2015-11-20 5:17 ` [PATCH v3 2/5] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos4 Alim Akhtar
2015-11-20 5:17 ` [PATCH v3 3/5] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos5 Alim Akhtar
2015-11-20 5:17 ` [PATCH v3 4/5] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos5410 SoC Alim Akhtar
2015-11-20 5:17 ` [PATCH v3 5/5] ARM: exynos: select POWER_RESET_SYSCON and POWER_RESET_SYSCON_POWEROFF Alim Akhtar
2015-11-20 6:49 ` Krzysztof Kozlowski
2015-12-01 9:03 ` Pavel Fedin
2015-12-02 5:21 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565E7FEB.3040806@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox