From: kapilh@broadcom•com (Kapil Hali)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/5] dt-bindings: add SMP enable-method for Broadcom NSP
Date: Sun, 6 Dec 2015 23:59:28 +0530 [thread overview]
Message-ID: <56647E88.6040002@broadcom.com> (raw)
In-Reply-To: <CAL_JsqLQuXzLpFJj7b=_pPN1Tp66P2o69bytxGPHCQu30Qy_CQ@mail.gmail.com>
Hi Rob,
On 12/6/2015 6:22 AM, Rob Herring wrote:
> On Wed, Dec 2, 2015 at 10:06 AM, Kapil Hali <kapilh@broadcom•com> wrote:
>> Hi Rob,
>>
>> On 12/2/2015 8:56 PM, Rob Herring wrote:
>>> On Tue, Dec 01, 2015 at 11:24:05AM -0500, Kapil Hali wrote:
>>>> Add a compatible string "brcm,bcm-nsp-smp" for Broadcom's
>>>> Northstar Plus CPU to the 32-bit ARM CPU device tree binding
>>>> documentation file and create a new binding documentation for
>>>> Northstar Plus CPU.
>>>>
>>>> Signed-off-by: Kapil Hali <kapilh@broadcom•com>
>>>> ---
>>>> .../bindings/arm/bcm/brcm,nsp-cpu-method.txt | 39 ++++++++++++++++++++++
>>>> Documentation/devicetree/bindings/arm/cpus.txt | 1 +
>>>> 2 files changed, 40 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,nsp-cpu-method.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,nsp-cpu-method.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp-cpu-method.txt
>>>> new file mode 100644
>>>> index 0000000..bf08872
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp-cpu-method.txt
>>>> @@ -0,0 +1,39 @@
>>>> +Broadcom Northstar Plus SoC CPU Enable Method
>>>> +---------------------------------------------
>>>> +This binding defines the enable method used for starting secondary
>>>> +CPUs in the following Broadcom SoCs:
>>>> + BCM58522, BCM58525, BCM58535, BCM58622, BCM58623, BCM58625, BCM88312
>>>> +
>>>> +The enable method is specified by defining the following required
>>>> +properties in the "cpus" device tree node:
>>>> + - enable-method = "brcm,bcm-nsp-smp";
>>>> + - secondary-boot-reg = <...>;
>>>
>>> Both of these are supposed to be per cpu core.
>>
>> 'enable-method' if not found in 'cpu' node is looked at in the 'cpus'
>> node. Except for two-three SoC families, 'enable-method' is within
>> 'cpus' node. Is my interpretation incorrect? Did I miss anything here?
>
> I'm not sure how you counted, but it is much more than 2-3 that are
> correct (including all of PPC). It is quite mixed in dts files, but it
> is documented to be per cpu node, so lets follow the documentation
> please.
>
> Rob
>
I looked at arch/arm/* and not other arch types. But, as you said, let
us keep it how it is in documentation and I have already updated latest
patch set reflecting this change.
Thanks,
Kapil
next prev parent reply other threads:[~2015-12-06 18:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 16:24 [PATCH v4 0/5] SMP support for Broadcom NSP Kapil Hali
2015-12-01 16:24 ` [PATCH v4 1/5] dt-bindings: add SMP enable-method " Kapil Hali
2015-12-01 23:06 ` Florian Fainelli
2015-12-02 15:26 ` Rob Herring
2015-12-02 16:06 ` Kapil Hali
2015-12-03 21:18 ` Florian Fainelli
2015-12-06 0:52 ` Rob Herring
2015-12-06 18:29 ` Kapil Hali [this message]
2015-12-01 16:24 ` [PATCH v4 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona Kapil Hali
2015-12-01 23:07 ` Florian Fainelli
2015-12-02 1:54 ` Florian Fainelli
2015-12-01 16:24 ` [PATCH v4 3/5] ARM: dts: Add SMP support for Broadcom NSP Kapil Hali
2015-12-01 23:07 ` Florian Fainelli
2015-12-01 16:24 ` [PATCH v4 4/5] ARM: BCM: " Kapil Hali
2015-12-01 23:07 ` Florian Fainelli
2015-12-01 16:24 ` [PATCH v4 5/5] ARM: BCM: Add SMP support for Broadcom 4708 Kapil Hali
2015-12-01 23:07 ` Florian Fainelli
2015-12-02 15:03 ` Hauke Mehrtens
2015-12-03 21:08 ` Jon Mason
2015-12-03 22:55 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56647E88.6040002@broadcom.com \
--to=kapilh@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox