From: dcashman@android•com (Daniel Cashman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.
Date: Mon, 7 Dec 2015 10:26:34 -0800 [thread overview]
Message-ID: <5665CF5A.1090207@android.com> (raw)
In-Reply-To: <1720878.JdEcLd8bhL@wuerfel>
On 12/07/2015 03:13 AM, Arnd Bergmann wrote:
> On Monday 07 December 2015 10:26:16 Jon Hunter wrote:
>>
>> diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c
>> index af461b935137..e59a75a308bc 100644
>> --- a/arch/arm64/mm/mmap.c
>> +++ b/arch/arm64/mm/mmap.c
>> @@ -51,7 +51,7 @@ unsigned long arch_mmap_rnd(void)
>> {
>> unsigned long rnd;
>>
>> -ifdef CONFIG_COMPAT
>> +#ifdef CONFIG_COMPAT
Thank you Jon. This ought to persuade me to do a final build against
the final patch, rather than the ugly porting I had been doing. I'll
include this in v6. (how embarassing =/)
>> if (test_thread_flag(TIF_32BIT))
>> rnd = (unsigned long)get_random_int() % (1 << mmap_rnd_compat_bits);
>> else
>>
>> Cheers
>>
>
> Ideally we'd remove the #ifdef around the mmap_rnd_compat_bits declaration
> and change this code to use
>
> if (IS_ENABLED(CONFIG_COMPAT) && test_thread_flag(TIF_32BIT))
>
> Arnd
That would result in "undefined reference to mmap_rnd_compat_bits" in
the not-defined case, no?
Thank You,
Dan
next prev parent reply other threads:[~2015-12-07 18:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 20:10 [PATCH v5 0/4] Allow customizable random offset to mmap_base address Daniel Cashman
2015-12-01 20:10 ` [PATCH v5 1/4] mm: mmap: Add new /proc tunable for mmap_base ASLR Daniel Cashman
2015-12-01 20:10 ` [PATCH v5 2/4] arm: mm: support ARCH_MMAP_RND_BITS Daniel Cashman
2015-12-01 20:10 ` [PATCH v5 3/4] arm64: " Daniel Cashman
2015-12-01 20:10 ` [PATCH v5 4/4] x86: " Daniel Cashman
2015-12-03 12:17 ` [PATCH v5 3/4] arm64: " Will Deacon
2015-12-03 16:12 ` Daniel Cashman
2015-12-07 10:26 ` Jon Hunter
2015-12-07 11:13 ` Arnd Bergmann
2015-12-07 18:26 ` Daniel Cashman [this message]
2015-12-08 10:03 ` Arnd Bergmann
2015-12-01 22:39 ` [PATCH v5 0/4] Allow customizable random offset to mmap_base address Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5665CF5A.1090207@android.com \
--to=dcashman@android$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox