From: javier@osg•samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs
Date: Mon, 7 Dec 2015 22:53:30 -0300 [thread overview]
Message-ID: <5666381A.1080206@osg.samsung.com> (raw)
In-Reply-To: <20151208003213.GU23396@atomide.com>
Hello Tony,
On 12/07/2015 09:32 PM, Tony Lindgren wrote:
> * Ulf Hansson <ulf.hansson@linaro•org> [151207 16:20]:
>> +Linus
>>
>> On 7 December 2015 at 23:54, Tony Lindgren <tony@atomide•com> wrote:
>>> Commit ce037275861e ("mmc: pwrseq_simple: use GPIO descriptors array API")
>>> changed the handling MMC power sequence so GPIOs no longer are optional.
>>>
>>> This broke SDIO WLAN at least for omap5 that can't yet use the reset GPIOs
>>> with pwrseq_simple as a wait is needed after enabling the SDIO device.
>>
>> Can you elaborate on this. Did it break omap5 or not? :-)
>
> Yes it broke WLAN for omap5 that I just got fixed.. It only uses the clocks
> art of the pwrseq currently because of the delay needed.
>
>> Also, I am interested to know more about the waiting period you need.
>> I assume that's because of the HW's characteristic?
>
> At least TI wl12xx and Marvell 8787 need a delay after enabling the the WLAN.
>
>> Why can't we have that being described in DT and then make
>> pwrseq_simple *wait* if needed?
>
> We can, but I'm thinking that we might be better off adding support for
> regulators to pwrseq. Both TI wl12xx and Marvell 8787 get power from the
> battery, and probably have an integrated regulator.
>
> Also, the delay and the power up sequencey can be more complicated than what
> we currently support. In the 8787 case, pdn pin needs to be asserted for 300ms
> after power pins are stable and while reset is held high.
>
>>> Let's fix the problem by allocating the GPIO values array during init
>>> depending on the optional GPIOs found.
>>
>> Certainly it shall be optional! I wonder how I could let that patch
>> slip through, my bad!
>
I also wonder how I missed that in my patch, sorry for the mess :(
> OK good to hear :)
>
>> Thanks for fixing this!
>
+1
> No problem, thanks,
>
> Tony
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-12-08 1:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 22:54 [PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs Tony Lindgren
2015-12-08 0:19 ` Ulf Hansson
2015-12-08 0:32 ` Tony Lindgren
2015-12-08 1:53 ` Javier Martinez Canillas [this message]
2015-12-08 13:17 ` Ulf Hansson
2015-12-08 15:57 ` Tony Lindgren
2015-12-18 16:14 ` Tony Lindgren
2015-12-18 22:19 ` Ulf Hansson
2015-12-18 22:31 ` Tony Lindgren
2015-12-28 12:18 ` Ulf Hansson
2015-12-28 21:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5666381A.1080206@osg.samsung.com \
--to=javier@osg$(echo .)samsung.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox