From: vladimir.murzin@arm•com (Vladimir Murzin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2] ARM: SWP emulation: Restore original *data when failed
Date: Tue, 08 Dec 2015 10:22:53 +0000 [thread overview]
Message-ID: <5666AF7D.5000703@arm.com> (raw)
In-Reply-To: <726a7ce88982fba5df84e4d22b083e39b57a6bc6.1444900732.git.shengjiu.wang@freescale.com>
On 15/10/15 10:30, Shengjiu Wang wrote:
> __user_swpX_asm maybe failed in first STREX operation, emulate_swpX
> will try again, but the *data has been changed in first time. which
> causes the result is wrong.
> This patch is to fix this issue. When STREX succeed, change the *data.
> if it fail, *data is not changed.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@freescale•com>
> ---
> arch/arm/kernel/swp_emulate.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/kernel/swp_emulate.c b/arch/arm/kernel/swp_emulate.c
> index 5b26e7e..c3fe769d 100644
> --- a/arch/arm/kernel/swp_emulate.c
> +++ b/arch/arm/kernel/swp_emulate.c
> @@ -36,10 +36,10 @@
> */
> #define __user_swpX_asm(data, addr, res, temp, B) \
> __asm__ __volatile__( \
> - " mov %2, %1\n" \
> - "0: ldrex"B" %1, [%3]\n" \
> - "1: strex"B" %0, %2, [%3]\n" \
> + "0: ldrex"B" %2, [%3]\n" \
> + "1: strex"B" %0, %1, [%3]\n" \
> " cmp %0, #0\n" \
> + " moveq %1, %2\n" \
> " movne %0, %4\n" \
> "2:\n" \
> " .section .text.fixup,\"ax\"\n" \
>
I wonder what is status of this patch? I see that arm64 counterpart has
landed in mainline, but I didn't manage to track down this one - is it
because it never been submitted to patch system?
Thanks
Vladimir
next prev parent reply other threads:[~2015-12-08 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 9:30 [PATCH V2] ARM: SWP emulation: Restore original *data when failed Shengjiu Wang
2015-12-08 10:22 ` Vladimir Murzin [this message]
2015-12-08 10:44 ` Russell King - ARM Linux
2015-12-08 12:41 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5666AF7D.5000703@arm.com \
--to=vladimir.murzin@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox