From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RFC 2/4] ARM: bcm2835: rename sdhci pin group
Date: Thu, 10 Dec 2015 22:19:16 -0700 [thread overview]
Message-ID: <566A5CD4.7080704@wwwdotorg.org> (raw)
In-Reply-To: <705524977.33360.5a38c754-5911-4377-aa1a-501587b3a337.open-xchange@email.1und1.de>
On 12/05/2015 02:43 AM, Stefan Wahren wrote:
>
>> Stephen Warren <swarren@wwwdotorg•org> hat am 2. Dezember 2015 um 04:42
>> geschrieben:
>>
>>
>> On 11/19/2015 09:06 AM, Stefan Wahren wrote:
>>> The node name of the sdhci pin group doesn't explain it's
>>> real function. So rename it.
>>
>> The real function of this node is not to configure SDHCI pins, but to
>> set pins to alt3, as the current name states. Admittedly it's possible
>> that currently the only pins that need to be set to ALT3 are SDHCI
>> related, but that's incidental.
>
> Yes, i understand the original intension to assign every pin to the available
> mux functions ( gpio_in, gpio_out, alt* ).
>
> But 3f37169fb3 ("ARM: bcm2835: dt: Add Raspberry Pi Model B rev2") introduce a
FYI I don't have that yet and git fetch is being very slow right now:-(
> better self-describing pin group naming for I2S. So my idea was to adapt it
> according to sdhci first and go on.
OK. I'd suggest explaining that directly in the commit description then.
The commit description above has a quite different semantic meaning.
> So here is a possible vision for bcm2835-rpi.dtsi
>
> &gpio {
> pinctrl-names = "default";
>
> act_gpio: gpio {
> brcm,pins = <6>;
> brcm,function = <BCM2835_FSEL_GPIO_OUT>;
> };
>
> i2c0_alt0: i2c {
> brcm,pins = <0 1>;
> brcm,function = <BCM2835_FSEL_ALT0>;
> };
>
> i2c1_alt0: i2c {
> brcm,pins = <2 3>;
> brcm,function = <BCM2835_FSEL_ALT0>;
> };
...
OK, I guess that can work; I imagine it would make DT overlays easier by
making the pinctrl setup more fine-grained.
next prev parent reply other threads:[~2015-12-11 5:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 16:06 [PATCH RFC 0/4] ARM: bcm2835: assign pins to sdhci pinctrl Stefan Wahren
2015-11-19 16:06 ` [PATCH RFC 1/4] ARM: bcm2835: remove sdhci pins from GPIO pinctrl Stefan Wahren
2015-12-02 3:40 ` Stephen Warren
2015-12-05 9:12 ` Stefan Wahren
2015-12-11 5:15 ` Stephen Warren
2015-11-19 16:06 ` [PATCH RFC 2/4] ARM: bcm2835: rename sdhci pin group Stefan Wahren
2015-12-02 3:42 ` Stephen Warren
2015-12-05 9:43 ` Stefan Wahren
2015-12-11 5:19 ` Stephen Warren [this message]
2015-11-19 16:06 ` [PATCH RFC 3/4] ARM: bcm2835: specify card detect pin for RPi B Stefan Wahren
2015-12-02 3:44 ` Stephen Warren
2015-12-02 16:33 ` Stefan Wahren
2015-11-19 16:06 ` [PATCH RFC 4/4] ARM: bcm2835: assign pins to sdhci pinctrl Stefan Wahren
2015-12-01 23:03 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566A5CD4.7080704@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox