From: xuejiancheng@huawei•com (xuejiancheng)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 3/7] ARM: hisi: add dt_machine definition for Hi3519
Date: Mon, 14 Dec 2015 10:07:43 +0800 [thread overview]
Message-ID: <566E246F.2050304@huawei.com> (raw)
In-Reply-To: <20151211152106.GB21272@rob-hp-laptop>
On 2015/12/11 23:21, Rob Herring wrote:
> On Fri, Dec 11, 2015 at 03:45:17PM +0800, Jiancheng Xue wrote:
>> add dt_machine definition for hi3519.
>>
>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei•com>
>> ---
>> arch/arm/mach-hisi/hisilicon.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/mach-hisi/hisilicon.c b/arch/arm/mach-hisi/hisilicon.c
>> index 8cc6215..010d8a2 100644
>> --- a/arch/arm/mach-hisi/hisilicon.c
>> +++ b/arch/arm/mach-hisi/hisilicon.c
>> @@ -81,3 +81,12 @@ static const char *const hip01_compat[] __initconst = {
>> DT_MACHINE_START(HIP01, "Hisilicon HIP01 (Flattened Device Tree)")
>> .dt_compat = hip01_compat,
>> MACHINE_END
>> +
>> +static const char *const hi3519_compat[] __initconst = {
>> + "hisilicon,hi3519",
>> + NULL,
>> +};
>
> You should just have 1 mach desc with multiple compatible strings to
> match against, not 1 mach desc per compatible string.
Yes, you're right. But Hi3519 is a soc in a new family. It doesn't belong to
any other existing mach descs. And more hi3519 compatible boards will be added
in this mach desc afterwards.
Can I do it like this now, and combine them at a proper time?
Or just add a more generic mach desc, then other socs like hix5hd2/hip01/hip04 can use this?
static const char *const hisilicon_compat[] __initconst = {
"hisilicon,hi3519",
NULL,
};
DT_MACHINE_START(HISILICON_DT, "Hisilicon")
.dt_compat = hisilicon_compat,
MACHINE_END
> Rob
>
>> +
>> +DT_MACHINE_START(HI3519_DT, "Hisilicon Hi3519")
>> + .dt_compat = hi3519_compat,
>> +MACHINE_END
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> .
>
next prev parent reply other threads:[~2015-12-14 2:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 7:45 [PATCH v3 0/7] ARM: hisi: Add initial support including clock driver for Hi3519 soc Jiancheng Xue
2015-12-11 7:45 ` [PATCH v3 1/7] clk: hisilicon: add CRG driver for hi3519 soc Jiancheng Xue
2015-12-11 7:45 ` [PATCH v3 2/7] clk: hisilicon: add dt-binding document for Hi3519 CRG Jiancheng Xue
2015-12-11 15:19 ` Rob Herring
2015-12-14 1:45 ` xuejiancheng
2015-12-11 7:45 ` [PATCH v3 3/7] ARM: hisi: add dt_machine definition for Hi3519 Jiancheng Xue
2015-12-11 15:21 ` Rob Herring
2015-12-14 2:07 ` xuejiancheng [this message]
2015-12-11 7:45 ` [PATCH v3 4/7] ARM: config: hisi: enable CONFIG_RESET_CONTROLLER Jiancheng Xue
2015-12-11 7:45 ` [PATCH v3 5/7] ARM: debug: add hi3519 debug uart Jiancheng Xue
2015-12-11 7:45 ` [PATCH v3 6/7] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Jiancheng Xue
2015-12-11 16:37 ` Rob Herring
2015-12-11 7:45 ` [PATCH v3 7/7] ARM: dts: add dts files for Hi3519 Jiancheng Xue
2015-12-11 16:28 ` Rob Herring
2015-12-14 6:34 ` xuejiancheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566E246F.2050304@huawei.com \
--to=xuejiancheng@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox