Subject: [PATCH V4 2/2] ARM: dts: imx6q: add Novena board

From: [email-masked] (Sergei Shtylyov)
Date: Mon, 14 Dec 2015 16:53:42 +0300

Hello.

On 12/14/2015 6:56 AM, Marek Vasut wrote:

>>> From: Sean Cross <[email-masked]>
>>>
>>> Novena is an open-hardware laptop/desktop/bare board.
>>>
>>> See http://www.kosagi.com/w/index.php?title=Novena_Main_Page
>>>
>>> Signed-off-by: Sean Cross <[email-masked]>
>>> Signed-off-by: Marek Vasut <[email-masked]>
>>> Cc: Fabio Estevam <[email-masked]>
>>> Cc: Lucas Stach <[email-masked]>
>>> Cc: Sean Cross <[email-masked]>
>>> Cc: Shawn Guo <[email-masked]>
>>
>> It looks pretty good to me now, except a small question below.
>
> Thanks
>
>>> ---
>>>
>>>   arch/arm/boot/dts/Makefile         |   1 +
>>>   arch/arm/boot/dts/imx6q-novena.dts | 789
>>>   +++++++++++++++++++++++++++++++++++++ 2 files changed, 790
>>>   insertions(+)
>>>   create mode 100644 arch/arm/boot/dts/imx6q-novena.dts
>>
>> <snip>
>>
>>> +/ {
>>> +	model = "Kosagi Novena Dual/Quad";
>>> +	compatible = "kosagi,imx6q-novena", "fsl,imx6q";
>>> +
>>> +	memory {
>>> +		reg = <0x10000000 0xefffffff>;
>>
>> What's the trick of having memory size being 0xefffffff?

> That is a typo, should obviously be 0xffffffff ,

    You didn't get it. :-) It' the _size_, not limit.

[...]

> Best regards,
> Marek Vasut

MBR, Sergei