From: vladimir.murzin@arm•com (Vladimir Murzin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver
Date: Tue, 15 Dec 2015 12:47:59 +0000 [thread overview]
Message-ID: <56700BFF.90001@arm.com> (raw)
In-Reply-To: <566EC5D2.9050005@linaro.org>
On 14/12/15 13:36, Daniel Lezcano wrote:
> On 12/02/2015 10:33 AM, Vladimir Murzin wrote:
>> MPS2 platform has simple 32 bits general purpose countdown timers.
>>
>> The driver uses the first detected timer as a clocksource and the rest
>> of the timers as a clockevent
>>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm•com>
>> ---
>
> [ ... ]
>
>> +static void clockevent_mps2_writel(u32 val, struct clock_event_device
>> *c, u32 offset)
>> +{
>> + writel(val, to_mps2_clkevt(c)->reg + offset);
>> +}
>
> Is it possible to use writel_relaxed here ?
I think it is possible. I'll update that part.
>
> [ ... ]
>
>> +static int mps2_timer_set_periodic(struct clock_event_device *ce)
>> +{
>> + u32 clock_count_per_tick = to_mps2_clkevt(ce)->clock_count_per_tick;
>> +
>> + clockevent_mps2_writel(clock_count_per_tick, ce, TIMER_RELOAD);
>> + clockevent_mps2_writel(clock_count_per_tick, ce, TIMER_VALUE);
>> + clockevent_mps2_writel(TIMER_CTRL_IE | TIMER_CTRL_ENABLE, ce,
>> TIMER_CTRL);
>> +
>> + return 0;
>> +}
>> +
>> +static irqreturn_t mps2_timer_interrupt(int irq, void *dev_id)
>> +{
>> + struct clockevent_mps2 *ce = dev_id;
>> + u32 status = readl(ce->reg + TIMER_INT);
>> +
>> + if (!status) {
>> + pr_warn("spuirous interrupt\n");
>
> typo: 'spurious'
>
> [ ... ]
>
>> + ce = kzalloc(sizeof(struct clockevent_mps2), GFP_KERNEL);
>> + if (!ce) {
>> + ret = -ENOMEM;
>> + pr_err("failed to allocate clockevent: %d\n", ret);
>
> There is already a stack trace in the kernel when an allocation fails.
>
> With the above fixed:
>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro•org>
>
>
All above fixed locally.
Thanks
Vladimir
next prev parent reply other threads:[~2015-12-15 12:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 9:33 [PATCH v1 00/10] Support for Cortex-M Prototyping System Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 01/10] dt-bindings: document the MPS2 timer bindings Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver Vladimir Murzin
2015-12-07 9:25 ` Vladimir Murzin
2015-12-14 13:36 ` Daniel Lezcano
2015-12-15 12:47 ` Vladimir Murzin [this message]
2015-12-14 13:56 ` Rob Herring
2015-12-15 13:16 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 03/10] dt-bindings: document the MPS2 UART bindings Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin
2015-12-07 9:26 ` Vladimir Murzin
2015-12-12 23:39 ` Andy Shevchenko
2015-12-13 7:00 ` Greg Kroah-Hartman
2015-12-15 12:40 ` Vladimir Murzin
2015-12-17 13:15 ` Andy Shevchenko
2015-12-02 9:33 ` [PATCH v1 05/10] serial: mps2-uart: add support for early console Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 06/10] ARM: mps2: introduce MPS2 platform Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 07/10] ARM: mps2: add low-level debug support Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 08/10] ARM: configs: add MPS2 defconfig Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin
2015-12-23 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 10/10] ARM: dts: introduce MPS2 AN399/AN400 Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56700BFF.90001@arm.com \
--to=vladimir.murzin@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox