From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 12/19] ARM: dts: exynos: replace legacy *, wakeup property with wakeup-source
Date: Thu, 17 Dec 2015 08:49:35 +0900 [thread overview]
Message-ID: <5671F88F.7050802@samsung.com> (raw)
In-Reply-To: <1445422216-29375-13-git-send-email-sudeep.holla@arm.com>
On 21.10.2015 19:10, Sudeep Holla wrote:
> Though the keyboard and other driver will continue to support the legacy
> "gpio-key,wakeup", "linux-keypad,wakeup" boolean property to enable the
> wakeup source, "wakeup-source" is the new standard binding.
>
> This patch replaces all the legacy wakeup properties with the unified
> "wakeup-source" property in order to avoid any futher copy-paste
> duplication.
>
> Cc: Kukjin Kim <kgene@kernel•org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung•com>
> Cc: linux-samsung-soc at vger.kernel.org
> Signed-off-by: Sudeep Holla <sudeep.holla@arm•com>
> ---
> arch/arm/boot/dts/exynos3250-monk.dts | 6 +++---
> arch/arm/boot/dts/exynos3250-rinato.dts | 6 +++---
> arch/arm/boot/dts/exynos4210-origen.dts | 10 +++++-----
> arch/arm/boot/dts/exynos4210-smdkv310.dts | 2 +-
> arch/arm/boot/dts/exynos4210-trats.dts | 2 +-
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++--
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 +-
> arch/arm/boot/dts/exynos4412-odroidx.dts | 2 +-
> arch/arm/boot/dts/exynos4412-origen.dts | 2 +-
> arch/arm/boot/dts/exynos4412-smdk4412.dts | 2 +-
> arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++--
> arch/arm/boot/dts/exynos5250-arndale.dts | 12 ++++++------
> arch/arm/boot/dts/exynos5250-snow.dts | 4 ++--
> arch/arm/boot/dts/exynos5250-spring.dts | 4 ++--
> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +-
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 ++--
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 ++--
> 17 files changed, 36 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
> index 540a0adf2be6..b77ea2163a0a 100644
> --- a/arch/arm/boot/dts/exynos3250-monk.dts
> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
> @@ -43,7 +43,7 @@
> linux,code = <KEY_POWER>;
> label = "power key";
> debounce-interval = <10>;
> - gpio-key,wakeup;
> + wakeup-source;
> };
> };
>
> @@ -67,7 +67,7 @@
> interrupt-parent = <&gpx1>;
> interrupts = <5 0>;
> reg = <0x25>;
> - wakeup;
> + wakeup-source;
>
> muic: max77836-muic {
> compatible = "maxim,max77836-muic";
> @@ -184,7 +184,7 @@
> interrupt-parent = <&gpx0>;
> interrupts = <7 0>;
> reg = <0x66>;
> - wakeup;
> + wakeup-source;
>
> s2mps14_osc: clocks {
> compatible = "samsung,s2mps14-clk";
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
> index 41a5fafb9aa9..7acd11d2d957 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -43,7 +43,7 @@
> linux,code = <KEY_POWER>;
> label = "power key";
> debounce-interval = <10>;
> - gpio-key,wakeup;
> + wakeup-source;
> };
> };
>
> @@ -58,7 +58,7 @@
> interrupt-parent = <&gpx1>;
> interrupts = <5 0>;
> reg = <0x25>;
> - wakeup;
> + wakeup-source;
>
> muic: max77836-muic {
> compatible = "maxim,max77836-muic";
> @@ -245,7 +245,7 @@
> interrupt-parent = <&gpx0>;
> interrupts = <7 0>;
> reg = <0x66>;
> - wakeup;
> + wakeup-source;
I think here and in Monk board these four "wakeup" properties are bogus,
not parsed by driver. Instead wakeup is always initialized to true.
Anyway fixing this is not part of this patch but instead this should be
fixed in separate commit. Here everything looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-12-16 23:49 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 10:09 [PATCH 00/19] devicetree: standardize/consolidate on "wakeup-source" property Sudeep Holla
2015-10-21 10:09 ` [PATCH 01/19] Documentation: " Sudeep Holla
2015-10-21 22:02 ` Rob Herring
2015-10-21 10:09 ` [PATCH 02/19] Documentation: devicetree: fix reference to legacy wakeup properties Sudeep Holla
2015-10-21 22:04 ` Rob Herring
2015-10-28 18:23 ` Sudeep Holla
2015-10-30 18:29 ` Rob Herring
2015-10-21 10:10 ` [PATCH 03/19] rtc: opal: enable support for the stardard "wakeup-source" property Sudeep Holla
2015-10-27 22:53 ` Alexandre Belloni
2015-10-21 10:10 ` [PATCH 04/19] rtc: isl12057: enable support for the standard " Sudeep Holla
2015-10-27 22:53 ` Alexandre Belloni
2015-10-21 10:10 ` [PATCH 05/19] mmc: core/host: " Sudeep Holla
2015-11-19 11:32 ` Ulf Hansson
2015-10-21 10:10 ` [PATCH 06/19] input: tegra-kbc: " Sudeep Holla
2015-10-23 6:39 ` Dmitry Torokhov
2015-10-23 10:23 ` Sudeep Holla
2015-10-26 8:33 ` Dmitry Torokhov
2015-10-21 10:10 ` [PATCH 07/19] ARM: dts: rockchip: replace gpio-key, wakeup with wakeup-source property Sudeep Holla
2015-10-21 10:10 ` [PATCH 08/19] ARM: dts: spear: " Sudeep Holla
2015-10-21 10:10 ` [PATCH 09/19] ARM: dts: am335x: " Sudeep Holla
2015-12-15 16:33 ` [PATCH 09/19] ARM: dts: am335x: replace gpio-key,wakeup " Sudeep Holla
2015-12-17 17:58 ` Tony Lindgren
2015-10-21 10:10 ` [PATCH 10/19] ARM: dts: at91: replace gpio-key, wakeup " Sudeep Holla
2015-10-21 10:21 ` [PATCH 10/19] ARM: dts: at91: replace gpio-key,wakeup " Nicolas Ferre
2015-10-21 10:25 ` Sudeep Holla
2015-10-21 11:01 ` Ulf Hansson
2015-10-21 11:13 ` Sudeep Holla
2015-10-21 12:41 ` Sudeep Holla
2015-10-21 15:27 ` Nicolas Ferre
2015-10-21 10:10 ` [PATCH 11/19] ARM: dts: imx: replace legacy *, wakeup property with wakeup-source Sudeep Holla
2015-11-23 5:37 ` [PATCH 11/19] ARM: dts: imx: replace legacy *,wakeup " Shawn Guo
2015-11-26 11:33 ` Sudeep Holla
2015-12-02 1:54 ` Shawn Guo
2015-12-02 10:05 ` Sudeep Holla
2015-10-21 10:10 ` [PATCH 12/19] ARM: dts: exynos: replace legacy *, wakeup " Sudeep Holla
2015-12-15 16:35 ` Sudeep Holla
2015-12-15 23:32 ` Krzysztof Kozlowski
2015-12-16 10:32 ` Sudeep Holla
2015-12-16 23:38 ` Krzysztof Kozlowski
2015-12-16 23:49 ` Krzysztof Kozlowski [this message]
2016-01-28 8:11 ` Krzysztof Kozlowski
2016-01-28 15:59 ` [UPDATE] " Sudeep Holla
2016-01-29 0:11 ` Krzysztof Kozlowski
2015-10-21 10:10 ` [PATCH 13/19] ARM: dts: tegra: " Sudeep Holla
2015-12-15 16:35 ` [PATCH 13/19] ARM: dts: tegra: replace legacy *,wakeup " Sudeep Holla
2015-12-23 11:24 ` Sudeep Holla
2015-10-21 10:10 ` [PATCH 14/19] ARM: dts: shmobile/r8a7xxx: replace gpio-key, wakeup with wakeup-source property Sudeep Holla
2015-10-21 10:18 ` Geert Uytterhoeven
2015-10-21 10:23 ` Sudeep Holla
2015-10-22 0:50 ` [PATCH 14/19] ARM: dts: shmobile/r8a7xxx: replace gpio-key,wakeup " Simon Horman
2015-10-22 9:37 ` [PATCH 14/19] ARM: dts: shmobile/r8a7xxx: replace gpio-key, wakeup " Sudeep Holla
2015-10-23 0:18 ` [PATCH 14/19] ARM: dts: shmobile/r8a7xxx: replace gpio-key,wakeup " Simon Horman
2015-10-21 10:10 ` [PATCH 15/19] ARM: dts: omap: replace legacy *, wakeup property with wakeup-source Sudeep Holla
2015-12-15 16:37 ` [PATCH 15/19] ARM: dts: omap: replace legacy *,wakeup " Sudeep Holla
2015-12-17 17:58 ` Tony Lindgren
2015-10-21 10:10 ` [PATCH 16/19] ARM: dts: s5pv210: replace legacy *, wakeup " Sudeep Holla
2015-12-15 16:37 ` Sudeep Holla
2015-12-16 23:52 ` Krzysztof Kozlowski
2015-10-21 10:10 ` [PATCH 17/19] ARM: dts: armada: replace isil, irq2-can-wakeup-machine with wakeup-source property Sudeep Holla
2015-12-15 16:39 ` [PATCH 17/19] ARM: dts: armada: replace isil,irq2-can-wakeup-machine " Sudeep Holla
2015-12-15 16:56 ` [PATCH 17/19] ARM: dts: armada: replace isil, irq2-can-wakeup-machine " Gregory CLEMENT
2015-10-21 10:10 ` [PATCH 18/19] ARM: dts: ste: replace legacy *, wakeup property with wakeup-source Sudeep Holla
2015-10-27 12:34 ` [PATCH 18/19] ARM: dts: ste: replace legacy *,wakeup " Linus Walleij
2015-10-27 12:46 ` Sudeep Holla
2015-11-05 9:26 ` Linus Walleij
2015-10-21 10:10 ` [PATCH 19/19] ARM: dts: zynq: replace gpio-key, wakeup with wakeup-source property Sudeep Holla
2015-10-29 8:56 ` [PATCH 19/19] ARM: dts: zynq: replace gpio-key,wakeup " Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5671F88F.7050802@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox