Subject: [PATCH v3 24/77] ncr5380: Implement NCR5380_dma_xfer_len and remove LIMIT_TRANSFERSIZE macro

From: [email-masked] (Hannes Reinecke)
Date: Tue, 22 Dec 2015 08:17:51 +0100

On 12/22/2015 02:18 AM, Finn Thain wrote:
> Follow the example of the atari_NCR5380.c core driver and adopt the
> NCR5380_dma_xfer_len() hook. Implement NCR5380_dma_xfer_len() for dtc.c
> and g_NCR5380.c to take care of the limitations of these cards. Keep the
> default for drivers using PSEUDO_DMA.
>
> Eliminate the unused macro LIMIT_TRANSFERSIZE.
>
> Signed-off-by: Finn Thain <[email-masked]>
>
> ---
>   drivers/scsi/NCR5380.c       |   32 +++++---------------------------
>   drivers/scsi/arm/cumana_1.c  |    3 +++
>   drivers/scsi/arm/oak.c       |    2 ++
>   drivers/scsi/atari_NCR5380.c |    8 +++++---
>   drivers/scsi/dtc.c           |   14 ++++++++++++++
>   drivers/scsi/dtc.h           |    3 +++
>   drivers/scsi/g_NCR5380.c     |   15 +++++++++++++++
>   drivers/scsi/g_NCR5380.h     |    3 +++
>   drivers/scsi/mac_scsi.c      |    1 +
>   drivers/scsi/pas16.h         |    2 ++
>   drivers/scsi/t128.h          |    2 ++
>   11 files changed, 55 insertions(+), 30 deletions(-)
>
Hmm. I really, _really_, wish we could move away from the 'magic' 
definitions and use a proper function template.
But maybe next time.

So:

Reviewed-by: Hannes Reinecke <[email-masked]>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare at suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)