From: zourongrong@huawei•com (Rongrong Zou)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v1 3/3] ARM64 LPC: update binding doc
Date: Sun, 3 Jan 2016 20:24:14 +0800 [thread overview]
Message-ID: <568912EE.9030009@huawei.com> (raw)
In-Reply-To: <CABTftiT1+AmrNjiAie-T6on-oWA4Zz73+Tj2pQrixMT3o475uw@mail.gmail.com>
? 2015/12/31 23:00, Rongrong Zou ??:
>
>
> 2015-12-31 22:40 GMT+08:00 Arnd Bergmann <arnd at arndb.de <mailto:arnd@arndb•de>>:
> >
> > On Thursday 31 December 2015 22:12:19 Rongrong Zou wrote:
> > > ? 2015/12/30 17:06, Arnd Bergmann ??:
> > > > On Tuesday 29 December 2015 21:33:52 Rongrong Zou wrote:
> > > >> +Example:
> > > >> +
> > > >> + lpc_0: lpc at a01b0000 {
> > > >> + #address-cells = <1>;
> > > >> + #size-cells = <1>;
> > > >> + compatible = "low-pin-count";
> > > >> + reg = <0x0 0xa01b0000 0x0 0x10000>;
> > > >> + };
> > > >
> > > > One more thought: please try to stick as closely as possible to the existing
> > > > ISA binding that is documented at
> > > >
> > > > http://www.firmware.org/1275/bindings/isa/isa0_4d.ps
> > > From the specification, I think I should use 2 32bit integer to describe the isa addr in dts.
> > > >
> > > > In particular, this should cover the possibility of describing both memory
> > > > and I/O spaces in child devices.
> > > >
> > >
> > > I found below config in powerpc dts "arch/powerpc/boot/dts/mpc8544ds.dts"
> > >
> > > isa at 1e {
> > > device_type = "isa";
> > > #interrupt-cells = <2>;
> > > #size-cells = <1>;
> > > #address-cells = <2>;
> > > reg = <0xf000 0x0 0x0 0x0 0x0>;
> > > ranges = <0x1 0x0 0x1000000 0x0 0x0
> > > 0x1000>;
> > > interrupt-parent = <&i8259>;
> > >
> > >
> > >
> > > rtc at 70 {
> > > compatible = "pnpPNP,b00";
> > > reg = <0x1 0x70 0x2>;
> > > };
> > > the isa space in child-node: reg = <0x1 0x70 0x2>;
> > > 0x1 means IO space, 70 means addr, 0x2 is size.
> > > but when i config the following in dts, the ipmi_0 node can't be probed,
> > > I think there may be some problems.
> > >
> > > lpc_0: lpc at a01b0000 {
> > > compatible = "low-pin-count";
> > > device_type = "isa";
> > > #address-cells = <2>;
> > > #size-cells = <1>;
> > > reg = <0x0 0xa01b0000 0x0 0x10000>;
> > >
> > > ipmi_0:ipmi at 000000e4{
> > > device_type = "ipmi";
> > > compatible = "ipmi-bt";
> > > reg = <0x1 0x000000e4 0x4>;
> > > };
> >
> > The DT sample above looks good in principle. I believe what you are missing
> > here is code in your driver to scan the child nodes to create the platform
> > devices. of_bus_isa_translate() should work with your definition here
> > and create the correct IORESOURCE_IO resources. You don't have any MMIO
> > resources, so the absence of a ranges property is ok. Maybe all you
> > are missing is a call to of_platform_populate() or of_platform_bus_probe()?
> >
>
> You are right. thanks, i'll try on test board . if i get the correct result , the new patch
> will be sent later. By the way, it's my another email account use when i at home.
I tried, and there need some additional changes.
isa at a01b0000 {
/*the node name should start with "isa", because of below definition
* static int of_bus_isa_match(struct device_node *np)
* {
* return !strcmp(np->name, "isa");
* }
*/
compatible = "low-pin-count";
device_type = "isa";
#address-cells = <2>;
#size-cells = <1>;
reg = <0x0 0xa01b0000 0x0 0x10000>;
ranges = <0x1 0x0 0x0 0x0 0x1000>;
/*
* ranges is required, then i can get the IORESOURCE_IO <0xe4,4> from "reg = <0x1, 0x000000e4, 4>".
*
*/
ipmi_0:ipmi at 000000e4{
device_type = "ipmi";
compatible = "ipmi-bt";
reg = <0x1 0x000000e4 0x4>;
};
drivers\of\address.c
static int __of_address_to_resource(struct device_node *dev,
const __be32 *addrp, u64 size, unsigned int flags,
const char *name, struct resource *r)
{
u64 taddr;
if ((flags & (IORESOURCE_IO | IORESOURCE_MEM)) == 0)
return -EINVAL;
taddr = of_translate_address(dev, addrp);
if (taddr == OF_BAD_ADDR)
return -EINVAL;
memset(r, 0, sizeof(struct resource));
if (flags & IORESOURCE_IO) {
unsigned long port;
/*****************************************************************/
/*legacy port(< 0x1000) is reserved, and need no translation here*/
/*****************************************************************/
if(taddr + size < PCIBIOS_MIN_IO){
r->start = taddr;
r->end = taddr + size - 1;
}
else{
port = pci_address_to_pio(taddr);
if (port == (unsigned long)-1)
return -EINVAL;
r->start = port;
r->end = port + size - 1;
}
} else {
r->start = taddr;
r->end = taddr + size - 1;
}
r->flags = flags;
r->name = name ? name : dev->full_name;
return 0;
}
>
> > Arnd
next parent reply other threads:[~2016-01-03 12:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1451396032-23708-1-git-send-email-zourongrong@gmail.com>
[not found] ` <1899302.RWIn6Bg3Dr@wuerfel>
[not found] ` <568537C3.3060902@huawei.com>
[not found] ` <17750582.ajK78gYOFz@wuerfel>
[not found] ` <CABTftiT1+AmrNjiAie-T6on-oWA4Zz73+Tj2pQrixMT3o475uw@mail.gmail.com>
2016-01-03 12:24 ` Rongrong Zou [this message]
2016-01-04 11:13 ` [PATCH v1 3/3] ARM64 LPC: update binding doc Arnd Bergmann
2016-01-04 16:04 ` Rongrong Zou
2016-01-04 16:34 ` Arnd Bergmann
2016-01-05 11:59 ` Rongrong Zou
2016-01-05 12:19 ` Arnd Bergmann
2016-01-06 13:36 ` Rongrong Zou
2016-01-07 3:37 ` Rongrong Zou
2016-01-10 9:29 ` Rolland Chau
2016-01-10 13:38 ` Rongrong Zou
2016-01-11 16:14 ` liviu.dudau at arm.com
2016-01-12 2:39 ` Rongrong Zou
2016-01-12 9:07 ` liviu.dudau at arm.com
2016-01-12 9:25 ` Rongrong Zou
2016-01-12 10:14 ` liviu.dudau at arm.com
2016-01-12 11:05 ` Rongrong Zou
2016-01-12 11:27 ` liviu.dudau at arm.com
2016-01-12 11:56 ` Rongrong Zou
2016-01-12 15:13 ` liviu.dudau at arm.com
2016-01-12 22:52 ` Arnd Bergmann
2016-01-13 5:53 ` Benjamin Herrenschmidt
2016-01-13 6:34 ` Rongrong Zou
2016-01-13 9:26 ` Arnd Bergmann
2016-01-13 10:10 ` liviu.dudau at arm.com
2016-01-13 10:18 ` Arnd Bergmann
2016-01-13 10:32 ` liviu.dudau at arm.com
2016-01-12 22:54 ` Arnd Bergmann
2016-01-13 10:09 ` liviu.dudau at arm.com
2016-01-13 10:29 ` Arnd Bergmann
2016-01-13 11:06 ` Rongrong Zou
2016-01-13 11:25 ` liviu.dudau at arm.com
[not found] ` <1628979.qkJQGmVH0I@wuerfel>
[not found] ` <5683A3B4.7040005@huawei.com>
[not found] ` <23432380.Bk9bdl2Z0r@wuerfel>
[not found] ` <20160104101124.GA1616@arm.com>
2016-01-04 10:27 ` [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Rongrong Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568912EE.9030009@huawei.com \
--to=zourongrong@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox