public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: zhaoshenglong@huawei•com (Shannon Zhao)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v8 3/4] arm64/arm, numa, dt: adding numa dt binding implementation for arm64 platforms.
Date: Mon, 4 Jan 2016 14:46:33 +0800	[thread overview]
Message-ID: <568A1549.9070405@huawei.com> (raw)
In-Reply-To: <1451385148-13448-4-git-send-email-gkulkarni@caviumnetworks.com>

Hi Ganapatrao,


On 2015/12/29 18:32, Ganapatrao Kulkarni wrote:
> +static int __init early_init_parse_memory_node(unsigned long node)
> +{
> +	const __be32 *reg, *endp;
> +	int length;
> +	int nid;
> +
> +	const char *type = of_get_flat_dt_prop(node, "device_type", NULL);
> +
> +	/* We are scanning "memory" nodes only */
> +	if (type == NULL)
> +		return 0;
> +	else if (strcmp(type, "memory") != 0)
> +		return 0;
> +
> +	nid = early_init_of_get_numa_nid(node);
> +
> +	if (nid == NUMA_NO_NODE)
> +		return -EINVAL;
> +
> +	reg = of_get_flat_dt_prop(node, "reg", &length);
> +	endp = reg + (length / sizeof(__be32));
> +
> +	while ((endp - reg) >= (dt_root_addr_cells + dt_root_size_cells)) {
> +		u64 base, size;
> +		struct memblock_region *mblk;
> +
> +		base = dt_mem_next_cell(dt_root_addr_cells, &reg);
> +		size = dt_mem_next_cell(dt_root_size_cells, &reg);
> +		pr_debug("NUMA-DT:  base = %llx , node = %u\n",
> +				base, nid);
> +
> +		for_each_memblock(memory, mblk) {
> +			if (mblk->base == base) {
> +				if (numa_add_memblk(nid,
> +							mblk->base,
> +							mblk->size) < 0)
> +					return -EINVAL;
> +				break;
> +			}
> +		}
> +	}
> +
> +	return 0;
> +}

Here it seems that you didn't address the comments[1] I gave on your
previous patch set.

[1] http://www.spinics.net/lists/devicetree/msg104493.html

Thanks,
-- 
Shannon

next prev parent reply	other threads:[~2016-01-04  6:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29 10:32 [PATCH v8 0/4] arm64, numa: Add numa support for arm64 platforms Ganapatrao Kulkarni
2015-12-29 10:32 ` [PATCH v8 1/4] arm64, numa: adding " Ganapatrao Kulkarni
2015-12-29 10:32 ` [PATCH v8 2/4] Documentation, dt, arm64/arm: dt bindings for numa Ganapatrao Kulkarni
2015-12-29 10:32 ` [PATCH v8 3/4] arm64/arm, numa, dt: adding numa dt binding implementation for arm64 platforms Ganapatrao Kulkarni
2016-01-04  6:46   ` Shannon Zhao [this message]
2016-01-04  7:18     ` Ganapatrao Kulkarni
2015-12-29 10:32 ` [PATCH v8 4/4] arm64, dt, thunderx: Add initial dts for Cavium Thunderx in 2 node topology Ganapatrao Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568A1549.9070405@huawei.com \
    --to=zhaoshenglong@huawei$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox