From: hpa@zytor•com (H. Peter Anvin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 6/6] arm64: switch to relative exception tables
Date: Mon, 04 Jan 2016 10:13:46 -0800 [thread overview]
Message-ID: <568AB65A.8030901@zytor.com> (raw)
In-Reply-To: <20160104144643.GE1616@arm.com>
On 01/04/2016 06:46 AM, Will Deacon wrote:
> On Sun, Jan 03, 2016 at 05:05:57PM +0100, Ard Biesheuvel wrote:
>> Instead of using absolute addresses for both the exception location
>> and the fixup, use offsets relative to the exception table entry values.
>> Not only does this cut the size of the exception table in half, it is
>> also a prerequisite for KASLR, since absolute exception table entries
>> are subject to dynamic relocation, which is incompatible with the sorting
>> of the exception table that occurs at build time.
>>
>> Cc: Catalin Marinas <catalin.marinas@arm•com>
>> Cc: Will Deacon <will.deacon@arm•com>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro•org>
>> ---
>>
>> Note that this patch supersedes the version I sent as part of the series that
>> implements KASLR for arm64: http://thread.gmane.org/gmane.linux.kernel/2116531
>>
>> arch/arm64/include/asm/assembler.h | 2 +-
>> arch/arm64/include/asm/futex.h | 4 ++--
>> arch/arm64/include/asm/uaccess.h | 18 ++++++++++--------
>> arch/arm64/kernel/armv8_deprecated.c | 4 ++--
>> arch/arm64/mm/extable.c | 2 +-
>> scripts/sortextable.c | 2 +-
>> 6 files changed, 17 insertions(+), 15 deletions(-)
>
> This looks good to me, so for the arm64 part (i.e. this patch):
>
> Acked-by: Will Deacon <will.deacon@arm•com>
May I humbly ask why the [Finnish] you don't use the equivalent of the
x86 _ASM_EXTABLE() macro? In fact, why don't we make that one generic, too?
-hpa
next prev parent reply other threads:[~2016-01-04 18:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 16:05 [PATCH 0/6] generic relative extable support Ard Biesheuvel
2016-01-03 16:05 ` [PATCH 1/6] extable: add support for relative extables to search and sort routines Ard Biesheuvel
2016-01-04 21:05 ` Helge Deller
2016-01-03 16:05 ` [PATCH 2/6] alpha/extable: use generic " Ard Biesheuvel
2016-01-03 16:05 ` [PATCH 3/6] s390/extable: " Ard Biesheuvel
2016-01-03 16:05 ` [PATCH 4/6] x86/extable: " Ard Biesheuvel
2016-01-03 16:05 ` [PATCH 5/6] ia64/extable: " Ard Biesheuvel
2016-01-03 16:05 ` [PATCH 6/6] arm64: switch to relative exception tables Ard Biesheuvel
2016-01-04 14:46 ` Will Deacon
2016-01-04 18:13 ` H. Peter Anvin [this message]
2016-01-04 18:20 ` Luck, Tony
2016-01-04 18:47 ` H. Peter Anvin
2016-01-04 19:21 ` H. Peter Anvin
2016-01-04 19:28 ` Ard Biesheuvel
2016-01-04 19:49 ` Luck, Tony
2016-01-04 11:20 ` [PATCH 0/6] generic relative extable support Heiko Carstens
2016-01-04 18:15 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568AB65A.8030901@zytor.com \
--to=hpa@zytor$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox