From: jonathanh@nvidia•com (Jon Hunter)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM64: tegra: Add support for Google Pixel C
Date: Wed, 6 Jan 2016 12:49:52 +0000 [thread overview]
Message-ID: <568D0D70.4020309@nvidia.com> (raw)
In-Reply-To: <20160106094616.GA563@leverpostej>
On 06/01/16 09:46, Mark Rutland wrote:
> Hi,
>
> On Wed, Jan 06, 2016 at 09:40:22AM +0000, Jon Hunter wrote:
>> Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based
>> upon Tegra210 SoC with 3 GiB of LPDDR4 RAM.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia•com>
>> ---
>> arch/arm64/boot/dts/nvidia/Makefile | 1 +
>> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 42 +++++++++++++++++++++++++++
>> 2 files changed, 43 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/Makefile b/arch/arm64/boot/dts/nvidia/Makefile
>> index a7e865da1005..0f7cdf3e05c1 100644
>> --- a/arch/arm64/boot/dts/nvidia/Makefile
>> +++ b/arch/arm64/boot/dts/nvidia/Makefile
>> @@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb
>> dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb
>> dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb
>> dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb
>> +dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb
>>
>> always := $(dtb-y)
>> clean-files := *.dtb
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> new file mode 100644
>> index 000000000000..a7474f5fcbcc
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> @@ -0,0 +1,42 @@
>> +/dts-v1/;
>> +
>> +#include "tegra210.dtsi"
>> +
>> +/ {
>> + model = "Google Pixel C";
>> + compatible = "google,smaug-rev8", "google,smaug-rev7",
>> + "google,smaug-rev6", "google,smaug-rev5",
>> + "google,smaug-rev4", "google,smaug-rev3",
>> + "google,smaug-rev1", "google,smaug", "nvidia,tegra210";
>
> This looks a little funky. Is each revision a strict superset of the
> previous version?
Yes this is based upon what Google have in the chromiumos branch [0] and
I have checked with them and they were ok with this.
Olof, let me know if you have any more comments here.
>> +
>> + chosen {
>> + bootargs = "console=ttyS0,115200n8 earlycon=uart8250,mmio32,0x70006000";
>> + };
>
> Use stdout-path.
Ok.
> Otherwise this looks ok.
Cheers
Jon
[0]
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.18/arch/arm64/boot/dts/tegra/tegra210-smaug-p1.dts
next prev parent reply other threads:[~2016-01-06 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 9:40 [PATCH] ARM64: tegra: Add support for Google Pixel C Jon Hunter
2016-01-06 9:46 ` Mark Rutland
2016-01-06 12:49 ` Jon Hunter [this message]
2016-01-07 13:19 ` Jon Hunter
2016-01-07 14:11 ` Arnd Bergmann
2016-01-07 16:53 ` Jon Hunter
2016-01-07 17:20 ` Rob Herring
2016-01-07 18:00 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568D0D70.4020309@nvidia.com \
--to=jonathanh@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox