From: jh80.chung@samsung•com (Jaehoon Chung)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a
Date: Thu, 07 Jan 2016 10:33:28 +0900 [thread overview]
Message-ID: <568DC068.6020602@samsung.com> (raw)
In-Reply-To: <CAFd313ziJ_zgxQ11J6e=ueRLFKXFOsDPg_evRDK2FGQC5rOmfA@mail.gmail.com>
Hi,
On 01/05/2016 07:25 PM, Rameshwar Sahu wrote:
> Hi Ulf,
>
> On Wed, Dec 23, 2015 at 6:59 PM, Rameshswar Prasad Sahu <rsahu@apm•com> wrote:
>> From: Rameshwar Prasad Sahu <rsahu@apm•com>
>>
>> The Arason SD host controller supports set block count command (cmd23)
>> and high speed mode. This patch re-enable both of these features that
>> was disabled. For device that doesn't support high speed, it should
>> configure its capability register accordingly instead disables it
>> explicitly.
>>
>> Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm•com>
>> ---
>> drivers/mmc/host/sdhci-of-arasan.c | 5 -----
>> 1 files changed, 0 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>> index 75379cb..5d9fdb3 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>> goto clk_disable_all;
>> }
>>
>> - if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
>> - host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
>> - host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
I'm not sure what's correct since i didn't have any information for arasan.
But in case of exynos, SDHCI_QUIRK_NO_HISPD_BIT is used because that bit is used as other purpose.
If your SoC is not used anymore, i think this patch looks good.
Best Regards,
Jaehoon Chung
>> - }
>> -
>> sdhci_get_of_property(pdev);
>> pltfm_host = sdhci_priv(host);
>> pltfm_host->priv = sdhci_arasan;
>> --
>> 1.7.1
>>
>
> Any comment on this patch ??
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2016-01-07 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1450877391-3029-1-git-send-email-rsahu@apm.com>
2016-01-05 10:25 ` [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a Rameshwar Sahu
2016-01-07 1:33 ` Jaehoon Chung [this message]
2016-01-07 12:32 ` Rameshwar Sahu
2016-01-27 14:15 ` Ulf Hansson
2015-12-22 13:20 Rameshwar Prasad Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568DC068.6020602@samsung.com \
--to=jh80.chung@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox