From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4.4-rc5 v22 2/4] irqchip: gic: Make gic_raise_softirq FIQ-safe
Date: Thu, 07 Jan 2016 14:35:46 +0000 [thread overview]
Message-ID: <568E77C2.9060002@arm.com> (raw)
In-Reply-To: <1450644757-18734-3-git-send-email-daniel.thompson@linaro.org>
On 20/12/15 20:52, Daniel Thompson wrote:
> It is currently possible for FIQ handlers to re-enter gic_raise_softirq()
> and lock up.
>
> gic_raise_softirq()
> lock(x);
> -~-> FIQ
> handle_fiq()
> gic_raise_softirq()
> lock(x); <-- Lockup
>
> arch/arm/ uses IPIs to implement arch_irq_work_raise(), thus this issue
> renders it difficult for FIQ handlers to safely defer work to less
> restrictive calling contexts.
>
> This patch fixes the problem by converting the cpu_map_migration_lock
> into a rwlock making it safe to re-enter the function.
>
> Note that having made it safe to re-enter gic_raise_softirq() we no
> longer need to mask interrupts during gic_raise_softirq() because the
> b.L migration is always performed from task context.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro•org>
> Cc: Thomas Gleixner <tglx@linutronix•de>
> Cc: Jason Cooper <jason@lakedaemon•net>
> Cc: Russell King <linux@arm•linux.org.uk>
> Cc: Marc Zyngier <marc.zyngier@arm•com>
> Acked-by: Nicolas Pitre <nicolas.pitre@linaro•org>
Acked-by: Marc Zyngier <marc.zyngier@arm•com>
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-01-07 14:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 20:52 [PATCH 4.4-rc5 v22 0/4] irq/arm: Use FIQ for NMI backtrace (when possible) Daniel Thompson
2015-12-20 20:52 ` [PATCH 4.4-rc5 v22 1/4] irqchip: gic: Optimize locking in gic_raise_softirq Daniel Thompson
2016-01-07 14:31 ` Marc Zyngier
2015-12-20 20:52 ` [PATCH 4.4-rc5 v22 2/4] irqchip: gic: Make gic_raise_softirq FIQ-safe Daniel Thompson
2016-01-07 14:35 ` Marc Zyngier [this message]
2015-12-20 20:52 ` [PATCH 4.4-rc5 v22 3/4] irqchip: gic: Introduce plumbing for IPI FIQ Daniel Thompson
2016-01-07 17:06 ` Marc Zyngier
2016-01-11 12:02 ` Daniel Thompson
2015-12-20 20:52 ` [PATCH 4.4-rc5 v22 4/4] ARM: Allow IPI_CPU_BACKTRACE to exploit FIQ Daniel Thompson
2015-12-20 22:12 ` kbuild test robot
2016-01-04 10:00 ` Daniel Thompson
2015-12-20 22:52 ` kbuild test robot
2016-01-04 10:05 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568E77C2.9060002@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox