From: s-anna@ti•com (Suman Anna)
To: linux-arm-kernel@lists•infradead.org
Subject: dra7xx pci driver broken on dra7xx-evm
Date: Thu, 7 Jan 2016 15:26:18 -0600 [thread overview]
Message-ID: <568ED7FA.4000508@ti.com> (raw)
In-Reply-To: <568DF4FE.5010704@ti.com>
On 01/06/2016 11:17 PM, Kishon Vijay Abraham I wrote:
> Hi,
+ Tero, Tony and linux-omap
>
> On Thursday 07 January 2016 03:15 AM, Richard Cochran wrote:
>>
>> The dra7xx-evm box freezes hard at the very first PCI bus access, the
>> call to in dra7xx_pcie_readl() in dra7xx_pcie_probe().
>>
>> The out-of-tree 3.14.53 TI driver performs a reset via platform data,
>> calling omap_device_assert_hardreset() by hook and crook.
Yeah, this is the only feasible way and not break multi-arch atm until a
reset framework is in place. We have couple of drivers (omap_iommu and
wkup_m3_rproc) following this approach.
>>
>> Adding the reset into the mainline driver cures the freeze.
>>
>> Question: How on earth is this driver supposed to work?
>
> It doesn't work out of the box in mainline. (Every time I post a PCI patch, I
> add the pdata-quirks mechanism to test it). The pdata-quirks mechanism used in
> TI tree is not an upstream-able solution. Something like this [1] was done for
> performing reset. Not sure the latest state of that. Dan? Suman?
Yeah, [1] is very old, and it doesn't deal with the hwmod integration
for pm_runtime API usage. Tero has posted another revamped series [2]
with hwmod integration, and it needs to be refreshed with few additional
patches and fixes. It will probably take couple of releases before it
hits mainline. So, I guess it is then a question of picking up the pdata
quirks solution for interim to get the driver functional until the reset
framework hits mainline, or mark the driver as broken.
regards
Suman
>
> [1] -> https://patches.linaro.org/33797/
[2] http://marc.info/?l=linux-omap&m=144310496514782&w=2
next prev parent reply other threads:[~2016-01-07 21:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 21:45 dra7xx pci driver broken on dra7xx-evm Richard Cochran
2016-01-07 5:17 ` Kishon Vijay Abraham I
2016-01-07 7:37 ` Richard Cochran
2016-01-07 8:11 ` [PATCH] arm: pci: mark the dra7xx driver as broken Richard Cochran
2016-01-07 8:44 ` Kishon Vijay Abraham I
2016-01-07 9:25 ` Richard Cochran
2016-01-07 14:42 ` Bjorn Helgaas
2016-01-08 6:55 ` Kishon Vijay Abraham I
2016-01-07 21:26 ` Suman Anna [this message]
2016-01-07 21:59 ` dra7xx pci driver broken on dra7xx-evm Tony Lindgren
2016-01-08 6:07 ` Kishon Vijay Abraham I
2016-01-08 9:22 ` Richard Cochran
2016-01-11 8:58 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568ED7FA.4000508@ti.com \
--to=s-anna@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox