From: wdc@rock-chips•com (David.Wu)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version
Date: Fri, 8 Jan 2016 21:12:29 +0800 [thread overview]
Message-ID: <568FB5BD.9050809@rock-chips.com> (raw)
In-Reply-To: <20160104194042.GD1522@katana>
Hi Wolfram, Andy
Thanks for your suggestion.
I will use i2c_parse_fw_timings() function to replace it.
? 2016/1/5 3:40, Wolfram Sang ??:
>>>> +static int rk3x_i2c_v0_calc_divs(unsigned long clk_rate, unsigned long
>>>> scl_rate,
>>>> + unsigned long scl_rise_ns,
>>>> + unsigned long scl_fall_ns,
>>>> + unsigned long sda_fall_ns,
>> Wolfram did some sturct to assign the parameters from device properties.
>> It might be re-used here.
> Yes, I think it makes sense to convert the driver first to use
> the new i2c_parse_fw_timings() function and see if it fits (or if we need
> to extend it perhaps).
>
> David, does this make sense to you?
>
prev parent reply other threads:[~2016-01-08 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 14:33 [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version David Wu
2015-12-11 14:33 ` [PATCH v1 2/3] i2c: rk3x: new way to calc_divs " David Wu
2015-12-11 14:33 ` [PATCH v1 3/3] i2c: rk3x: support I2C Hs-mode for rk3399 David Wu
2015-12-15 0:32 ` [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version Jianqun Xu
2015-12-20 15:43 ` Andy Shevchenko
2016-01-04 19:40 ` Wolfram Sang
2016-01-08 13:12 ` David.Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568FB5BD.9050809@rock-chips.com \
--to=wdc@rock-chips$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox